* wm8400-core: select REGMAP_I2C in kconfig
@ 2011-10-25 18:54 Dave Jones
2011-10-26 7:12 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Dave Jones @ 2011-10-25 18:54 UTC (permalink / raw)
To: Mark Brown; +Cc: Linux Kernel
wm8400-core.c is using the regmap I2C API, so needs to select it.
ERROR: "regmap_write" [drivers/mfd/wm8400-core.ko] undefined!
ERROR: "regmap_raw_read" [drivers/mfd/wm8400-core.ko] undefined!
ERROR: "regmap_read" [drivers/mfd/wm8400-core.ko] undefined!
ERROR: "regmap_init_i2c" [drivers/mfd/wm8400-core.ko] undefined!
ERROR: "regmap_bulk_read" [drivers/mfd/wm8400-core.ko] undefined!
ERROR: "regmap_exit" [drivers/mfd/wm8400-core.ko] undefined!
Signed-off-by: Dave Jones <davej@redhat.com>
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index a67adcb..67a6126 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -389,6 +389,7 @@ config MFD_MAX8998
config MFD_WM8400
tristate "Support Wolfson Microelectronics WM8400"
select MFD_CORE
+ select REGMAP_I2C
depends on I2C
help
Support for the Wolfson Microelecronics WM8400 PMIC and audio
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: wm8400-core: select REGMAP_I2C in kconfig
2011-10-25 18:54 wm8400-core: select REGMAP_I2C in kconfig Dave Jones
@ 2011-10-26 7:12 ` Mark Brown
2011-10-26 13:43 ` Dave Jones
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2011-10-26 7:12 UTC (permalink / raw)
To: Dave Jones, Linux Kernel
On Tue, Oct 25, 2011 at 02:54:00PM -0400, Dave Jones wrote:
> wm8400-core.c is using the regmap I2C API, so needs to select it.
>
> ERROR: "regmap_write" [drivers/mfd/wm8400-core.ko] undefined!
> ERROR: "regmap_raw_read" [drivers/mfd/wm8400-core.ko] undefined!
> ERROR: "regmap_read" [drivers/mfd/wm8400-core.ko] undefined!
> ERROR: "regmap_init_i2c" [drivers/mfd/wm8400-core.ko] undefined!
> ERROR: "regmap_bulk_read" [drivers/mfd/wm8400-core.ko] undefined!
> ERROR: "regmap_exit" [drivers/mfd/wm8400-core.ko] undefined!
Which kernel version are you looking at? This is correct in my current
kernel - fixed in commit 2b247d06. Though I suspect that's waiting to
trickle down into Linus' tree still.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: wm8400-core: select REGMAP_I2C in kconfig
2011-10-26 7:12 ` Mark Brown
@ 2011-10-26 13:43 ` Dave Jones
2011-10-26 13:47 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Dave Jones @ 2011-10-26 13:43 UTC (permalink / raw)
To: Mark Brown; +Cc: Linux Kernel
On Wed, Oct 26, 2011 at 09:12:59AM +0200, Mark Brown wrote:
> On Tue, Oct 25, 2011 at 02:54:00PM -0400, Dave Jones wrote:
> > wm8400-core.c is using the regmap I2C API, so needs to select it.
> >
> > ERROR: "regmap_write" [drivers/mfd/wm8400-core.ko] undefined!
> > ERROR: "regmap_raw_read" [drivers/mfd/wm8400-core.ko] undefined!
> > ERROR: "regmap_read" [drivers/mfd/wm8400-core.ko] undefined!
> > ERROR: "regmap_init_i2c" [drivers/mfd/wm8400-core.ko] undefined!
> > ERROR: "regmap_bulk_read" [drivers/mfd/wm8400-core.ko] undefined!
> > ERROR: "regmap_exit" [drivers/mfd/wm8400-core.ko] undefined!
>
> Which kernel version are you looking at? This is correct in my current
> kernel - fixed in commit 2b247d06. Though I suspect that's waiting to
> trickle down into Linus' tree still.
That was yesterdays git (don't have the hash handy). Today, as of
efb8d21b2c6db3497655cc6a033ae8a9883e4063 I can't reproduce it, though
I don't know why, as that file is definitly still using regmap, and there's
no select, and it's not in my .config.
Dave
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: wm8400-core: select REGMAP_I2C in kconfig
2011-10-26 13:43 ` Dave Jones
@ 2011-10-26 13:47 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2011-10-26 13:47 UTC (permalink / raw)
To: Dave Jones, Linux Kernel
On Wed, Oct 26, 2011 at 09:43:58AM -0400, Dave Jones wrote:
> That was yesterdays git (don't have the hash handy). Today, as of
> efb8d21b2c6db3497655cc6a033ae8a9883e4063 I can't reproduce it, though
> I don't know why, as that file is definitly still using regmap, and there's
> no select, and it's not in my .config.
I guess it's not terribly important so long as the patch I mentioned
that's in Samuel's tree makes it in during the merge window.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-26 13:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-25 18:54 wm8400-core: select REGMAP_I2C in kconfig Dave Jones
2011-10-26 7:12 ` Mark Brown
2011-10-26 13:43 ` Dave Jones
2011-10-26 13:47 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).