From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754972Ab1JZNJE (ORCPT ); Wed, 26 Oct 2011 09:09:04 -0400 Received: from mail.elliptictech.com ([209.217.122.41]:57235 "EHLO mail.ellipticsemi.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751447Ab1JZNJB (ORCPT ); Wed, 26 Oct 2011 09:09:01 -0400 Date: Wed, 26 Oct 2011 09:08:34 -0400 From: Nick Bowler To: Greg KH Cc: Dave Jones , Ben Hutchings , Rusty Russell , Randy Dunlap , LKML , Debian kernel maintainers Subject: Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree Message-ID: <20111026130834.GA6387@elliptictech.com> References: <1319461948.31243.31.camel@deadeye> <4EA57CBF.2050901@xenotime.net> <87k47tpvvm.fsf@rustcorp.com.au> <20111025153855.GA24779@elliptictech.com> <1319558749.11727.6.camel@deadeye> <20111025165142.GA25354@elliptictech.com> <20111025200455.GA6376@kroah.com> <20111025201723.GA25063@redhat.com> <20111025205410.GA7479@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111025205410.GA7479@kroah.com> Organization: Elliptic Technologies Inc. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2011-10-25 22:54 +0200, Greg KH wrote: > On Tue, Oct 25, 2011 at 04:17:24PM -0400, Dave Jones wrote: > > On Tue, Oct 25, 2011 at 10:04:55PM +0200, Greg Kroah-Hartman wrote: > > > On Tue, Oct 25, 2011 at 12:51:42PM -0400, Nick Bowler wrote: > > > > This is not the case: lockdep works fine with staging modules. > > > > > > Yes, that was fixed a few kernel versions ago. > > > > > > Now you might want to update that fix for the TAINT_OOT_MODULE flag as > > > well, if you feel it is needed. > > > > I'm assuming you mean this patch ? > > > > commit 7816c45bf13255157c00fb8aca86cb64d825e878 > > Author: Roland Vossen > > Date: Thu Apr 7 11:20:58 2011 +0200 > > > > modules: Enabled dynamic debugging for staging modules > > Hm, this is the patch I was thinking about yes. But as you point out: [...] > Perhaps the lockdep thing is totally different. I don't know about that > check. Lockdep is disabled (for the whole system) by add_taint itself. The relevant commit that fixes TAINT_CRAP appears to be this one (circa 2.6.30): commit 574bbe782057fdf0490dc7dec906a2dc26363e20 Author: Frederic Weisbecker Date: Sat Apr 11 03:17:18 2009 +0200 lockdep: continue lock debugging despite some taints I didn't know about the dynamic debug problem. Is there more breakage that we haven't found yet? Remind me why we're trying to cripple out of tree module users? Cheers, -- Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)