From: Dave Jones <davej@redhat.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: wm8400-core: select REGMAP_I2C in kconfig
Date: Wed, 26 Oct 2011 09:43:58 -0400 [thread overview]
Message-ID: <20111026134358.GA2048@redhat.com> (raw)
In-Reply-To: <20111026071256.GA2915@opensource.wolfsonmicro.com>
On Wed, Oct 26, 2011 at 09:12:59AM +0200, Mark Brown wrote:
> On Tue, Oct 25, 2011 at 02:54:00PM -0400, Dave Jones wrote:
> > wm8400-core.c is using the regmap I2C API, so needs to select it.
> >
> > ERROR: "regmap_write" [drivers/mfd/wm8400-core.ko] undefined!
> > ERROR: "regmap_raw_read" [drivers/mfd/wm8400-core.ko] undefined!
> > ERROR: "regmap_read" [drivers/mfd/wm8400-core.ko] undefined!
> > ERROR: "regmap_init_i2c" [drivers/mfd/wm8400-core.ko] undefined!
> > ERROR: "regmap_bulk_read" [drivers/mfd/wm8400-core.ko] undefined!
> > ERROR: "regmap_exit" [drivers/mfd/wm8400-core.ko] undefined!
>
> Which kernel version are you looking at? This is correct in my current
> kernel - fixed in commit 2b247d06. Though I suspect that's waiting to
> trickle down into Linus' tree still.
That was yesterdays git (don't have the hash handy). Today, as of
efb8d21b2c6db3497655cc6a033ae8a9883e4063 I can't reproduce it, though
I don't know why, as that file is definitly still using regmap, and there's
no select, and it's not in my .config.
Dave
next prev parent reply other threads:[~2011-10-26 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 18:54 wm8400-core: select REGMAP_I2C in kconfig Dave Jones
2011-10-26 7:12 ` Mark Brown
2011-10-26 13:43 ` Dave Jones [this message]
2011-10-26 13:47 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111026134358.GA2048@redhat.com \
--to=davej@redhat.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).