From: Seth Forshee <seth.forshee@canonical.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Azael Avalos <coproscefalo@gmail.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] toshiba_acpi: Cleanup and TOS1900 device support
Date: Wed, 26 Oct 2011 08:54:32 -0500 [thread overview]
Message-ID: <20111026135432.GA31917@thinkpad-t410> (raw)
In-Reply-To: <20110921161043.GC29983@thinkpad-t410>
On Wed, Sep 21, 2011 at 11:10:44AM -0500, Seth Forshee wrote:
> On Wed, Sep 21, 2011 at 04:31:37PM +0100, Matthew Garrett wrote:
> > On Tue, Sep 20, 2011 at 04:55:48PM -0500, Seth Forshee wrote:
> > > Hi Matthew,
> > >
> > > Please consider merging the following patches. They represent a
> > > signficant cleanup of toshiba_acpi as well as adding support for SPFC as
> > > an HCI method. The latter provides basic but functional support for the
> > > TOS1900 devices found on newer Toshiba models, which will serve as a
> > > good starting point for further enhancements. I've tried to leave the
> > > details of the hardware interaction unchanged to reduce the risk of
> > > regression for machines already supported by the driver.
> >
> > Great. Has this been tested on any older hardware? I'd think that the
> > risk of regression is pretty low, but it'd be a nice sanity check. I've
> > only got one TOS1800 type around here, and it's a 1.2GHz Pentium M, so
> > I'd prefer to have got someone else to do it :)
>
> No, I don't have any older hardware to test on, and I'm pretty sure
> Azael doesn't either. Not that I want to afflict any additional pain
> beyond what you already have from dealing with firmware all day ;)
I managed to find some volunteers with machines that use the GHCI
interface to do some regression testing for me. They aren't exactly
older hardware, all of them with TOS6208 and being made within the last
2 or 3 years. But it's the best I could do.
None of the machines tested showed any regressions as a result of these
patches. I also got testing of using the INFO method to read hotkey
scancodes, and that's working on those machines as well. (I did however
find that I had to reintroduce the global toshiba_acpi pointer for the
i8042 filter, since it doesn't have any mechanism for passing private
data to the callback.)
Any chance of seeing these patches in 3.2?
next prev parent reply other threads:[~2011-10-26 13:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 21:55 [PATCH 0/6] toshiba_acpi: Cleanup and TOS1900 device support Seth Forshee
2011-09-20 21:55 ` [PATCH 1/6] toshiba_acpi: Convert to use acpi_driver Seth Forshee
2011-09-20 22:17 ` Joe Perches
2011-09-21 7:31 ` Corentin Chary
2011-09-21 12:52 ` Seth Forshee
2011-09-21 7:28 ` Corentin Chary
2011-09-21 13:24 ` Seth Forshee
2011-09-21 13:30 ` Corentin Chary
2011-09-21 15:13 ` Azael Avalos
2011-09-21 15:35 ` Matthew Garrett
2011-09-20 21:55 ` [PATCH 2/6] toshiba_acpi: Fix up return codes Seth Forshee
2011-09-20 21:55 ` [PATCH 3/6] toshiba_acpi: Use handle for HCI calls Seth Forshee
2011-09-20 21:55 ` [PATCH 4/6] toshiba_acpi: Support SPFC as an HCI method Seth Forshee
2011-09-20 21:55 ` [PATCH 5/6] toshiba_acpi: Don't add devices for unsupported features Seth Forshee
2011-09-20 21:55 ` [PATCH 6/6] toshiba_acpi: Initialize brightness in backlight device Seth Forshee
2011-09-21 15:31 ` [PATCH 0/6] toshiba_acpi: Cleanup and TOS1900 device support Matthew Garrett
2011-09-21 16:10 ` Seth Forshee
2011-10-26 13:54 ` Seth Forshee [this message]
2011-10-26 16:58 ` Azael Avalos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111026135432.GA31917@thinkpad-t410 \
--to=seth.forshee@canonical.com \
--cc=coproscefalo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).