Re: [PATCH 4/5] hpsa: fix potential array overflow in hpsa_update_scsi_devices

James Bottomley
2011-10-30T10:16:28Z

On Wed, 2011-10-26 at 16:21 -0500, Stephen M. Cameron wrote:
> From: Scott Teel <scott.teel@hp.com>
>
> The currentsd[] array in hpsa_update_scsi_devices had room for
> 256 devices. The code was iterating over however many physical
> and logical devices plus an additional number of possible external
> MSA2XXX controllers, which together could potentially exceed 256.
>
> We increased the size of the currentsd array to 1024 + 1024 + 32 + 1
> elements to reflect a reasonable maximum possible number of devices
> which might be encountered. We also don't just walk off the end
> of the array if the array controller reports more devices than we
> are prepared to handle, we just ignore the excessive devices.
>
> Signed-off-by: Scott Teel <scott.teel@hp.com>
> Acked-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>

This should be Signed-off-by not Acked-by. The reason is that the
signoffs track whose hands the patch passes through. If you send
Scott's patch to me, it must have your signoff. If Scott sends the
patch directly to me and then you OK it on the list, then I'll add
Acked-by. I've assumed your acquiescence to correcting this in my tree.

James