From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Michael Holzheu <holzheu@linux.vnet.ibm.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
schwidefsky@de.ibm.com, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, Kay Sievers <kay.sievers@vrfy.org>,
Dave Hansen <haveblue@us.ibm.com>
Subject: Re: kdump: No udev events for memory hotplug?
Date: Thu, 27 Oct 2011 09:30:58 +0200 [thread overview]
Message-ID: <20111027073058.GA2422@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <20111026192449.GE355@redhat.com>
On Wed, Oct 26, 2011 at 03:24:49PM -0400, Vivek Goyal wrote:
> On Wed, Oct 26, 2011 at 06:08:12PM +0200, Michael Holzheu wrote:
> > Hello Vivek and Eric,
> >
> > I noticed that on my system kernel 3.1 *no* udev events for memory
> > hotplug are generated. Same on my RHEL6.1.
> >
> > # udevadm monitor
> > # echo offline > /sys/devices/system/memory/memory4/state
> >
> > -> No event
> >
> > But we need the udev events in order to do a kdump reload for setting up
> > the ELF loads correctly.
> >
> > In my /etc/udev/rules.d/98-kexec.rules there are rules for memory
> > hotplug:
> >
> > SUBSYSTEM=="memory", ACTION=="add", PROGRAM="/etc/init.d/kdump restart"
> > SUBSYSTEM=="memory", ACTION=="remove", PROGRAM="/etc/init.d/kdump
> > restart"
> >
> > Perhaps/probably I am missing something?
>
> I don't know. Sounds like a bug. I have never looked into it. CCing Kay,
> if he has any thoughts.
>
> Are any events generated for memory add?
Looks like uevents are only genereted when memory gets registered and
unregistered, but not when when it gets set online or offline.
To achieve that you would need to add similar code to
store_mem_state()/memory_block_change_state() in drivers/base/memory.c
like we have it already in store_online() in drivers/base/cpu.c
next prev parent reply other threads:[~2011-10-27 7:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 16:08 kdump: No udev events for memory hotplug? Michael Holzheu
2011-10-26 19:24 ` Vivek Goyal
2011-10-27 7:30 ` Heiko Carstens [this message]
2011-10-27 9:32 ` [PATCH] kdump: Add udev events for memory online/offline Michael Holzheu
2011-10-28 22:41 ` Andrew Morton
2011-10-28 22:57 ` Dave Hansen
2011-10-28 22:46 ` Andrew Morton
2011-10-31 13:21 ` [PATCH v2] " Michael Holzheu
2011-11-14 2:37 ` WANG Cong
2011-10-27 12:45 ` kdump: No udev events for memory hotplug? Dave Hansen
2011-10-27 13:18 ` Américo Wang
2011-10-27 7:45 ` Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111027073058.GA2422@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=ebiederm@xmission.com \
--cc=haveblue@us.ibm.com \
--cc=holzheu@linux.vnet.ibm.com \
--cc=kay.sievers@vrfy.org \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox