From: Sam Ravnborg <sam@ravnborg.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Michal Marek <mmarek@suse.cz>,
Pekka Enberg <penberg@cs.helsinki.fi>,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] config: Add 'make kvmconfig'
Date: Thu, 27 Oct 2011 21:34:48 +0200 [thread overview]
Message-ID: <20111027193448.GA3514@merkur.ravnborg.org> (raw)
In-Reply-To: <1319717234-20918-1-git-send-email-levinsasha928@gmail.com>
On Thu, Oct 27, 2011 at 02:07:14PM +0200, Sasha Levin wrote:
> This patch adds 'make kvmconfig' which allows to add KVM guest support
> to a config file.
>
> This allows for easier testing of configurations under virtualized
> environments.
>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Michal Marek <mmarek@suse.cz>
> Cc: Pekka Enberg <penberg@cs.helsinki.fi>
> Cc: linux-kbuild@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Suggested-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
Two points about the implmentation that I do not like...
The kvmconfig is an x86 specific thing - so it does not belong
in the scripts/kconfig/Makefile
The *config namespace is general config targets.
Suggestion:
Move the implmentation to arch/x86/Makefile and name the target
something that does not match the *config pattern.
Suggestion:
make kvmbootable
To tell that this convert the current config to a kvmbootable config.
And then add the target to the x86 specific help too.
Sam
next prev parent reply other threads:[~2011-10-27 19:34 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-27 12:07 [PATCH] config: Add 'make kvmconfig' Sasha Levin
2011-10-27 12:12 ` Pekka Enberg
2011-10-27 12:37 ` Ingo Molnar
2011-10-27 12:51 ` Michal Marek
2011-10-27 13:34 ` Ingo Molnar
2011-10-27 14:11 ` Pekka Enberg
2011-10-27 14:32 ` Michal Marek
2011-10-27 15:05 ` Arnaud Lacombe
2011-10-27 15:19 ` Arnaud Lacombe
2011-10-27 15:30 ` Pekka Enberg
2011-10-27 18:05 ` Rabin Vincent
2011-10-27 20:46 ` Sasha Levin
2011-10-27 19:34 ` Sam Ravnborg [this message]
2011-10-28 7:03 ` Ingo Molnar
2011-10-28 7:23 ` Sasha Levin
2011-10-28 7:39 ` Ingo Molnar
2011-10-28 7:47 ` Sasha Levin
2011-10-28 7:52 ` Ingo Molnar
2011-10-28 7:52 ` Geert Uytterhoeven
2011-10-28 7:54 ` Ingo Molnar
2011-10-28 12:08 ` Matthias Schniedermeyer
2011-10-28 12:29 ` Ingo Molnar
2011-10-28 13:05 ` Matthias Schniedermeyer
2011-11-02 8:41 ` Ingo Molnar
2011-11-02 9:07 ` Michal Marek
2011-11-02 9:17 ` Ingo Molnar
2011-11-02 9:24 ` Michal Marek
2011-11-02 9:39 ` Ingo Molnar
2011-11-02 10:06 ` Pekka Enberg
2011-10-28 9:16 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111027193448.GA3514@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=levinsasha928@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mmarek@suse.cz \
--cc=penberg@cs.helsinki.fi \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).