public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Linux PM mailing list <linux-pm@lists.linux-foundation.org>,
	Tejun Heo <tj@kernel.org>, Alan Stern <stern@rowland.harvard.edu>,
	Greg KH <greg@kroah.com>, LKML <linux-kernel@vger.kernel.org>,
	Magnus Damm <magnus.damm@gmail.com>,
	Kevin Hilman <khilman@ti.com>,
	linux-scsi@vger.kernel.org,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	stable@kernel.org
Subject: Re: [PATCH 4/6 v2] PM: Limit race conditions between runtime PM and system sleep (v2)
Date: Thu, 27 Oct 2011 22:06:34 +0200	[thread overview]
Message-ID: <201110272206.35180.rjw@sisk.pl> (raw)
In-Reply-To: <CAKnu2Mru4c-2LBCZ_k3ZA+v47u0+um8igYU7EWt8=qOTVgcUjA@mail.gmail.com>

On Thursday, October 27, 2011, Linus Walleij wrote:
> 2011/6/29 Rafael J. Wysocki <rjw@sisk.pl>:
> 
> > One of the roles of the PM core is to prevent different PM callbacks
> > executed for the same device object from racing with each other.
> > Unfortunately, after commit e8665002477f0278f84f898145b1f141ba26ee26
> > (PM: Allow pm_runtime_suspend() to succeed during system suspend)
> > runtime PM callbacks may be executed concurrently with system
> > suspend/resume callbacks for the same device.
> (...)
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> 
> A quick question: is there some specific reason why this patch should
> not go into the 3.0.y stable releases?
>
> We are trying to produce
> a runtime PM system of product quality based on 3.0.y and we've
> already had to backport this patch ourselves to get things stable.
> 
> We have also backported:
> PM: Introduce generic "noirq" callback routines for subsystems (v2)
> PM / Runtime: Update documentation of interactions with system sleep
> PM / Runtime: Add new helper function: pm_runtime_status_suspended()
> 
> And now it seems to be sufficient to get this thing going.

Well, it isn't a simple fix and it changes the code's behavior quite
significantly, so I thought it might not be a good idea to risk problems
with -stable because of it.  Perhaps let's see how it works out in 3.1
and backport it later if there are no problem reports related to it?

Rafael

  reply	other threads:[~2011-10-27 20:04 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-25 22:54 [PATCH 0/3] PM: Fix up interactions between system suspend/resume and runtime PM Rafael J. Wysocki
2011-06-25 22:55 ` [PATCH 1/3] PM / Runtime: Update documentation of interactions with system sleep Rafael J. Wysocki
2011-06-25 22:58   ` Jesper Juhl
2011-06-26  3:01     ` Alan Stern
2011-06-26 20:12       ` Rafael J. Wysocki
2011-06-25 22:55 ` [PATCH 2/3] PM / Runtime: Return special error code if runtime PM is disabled Rafael J. Wysocki
2011-06-25 22:56 ` [PATCH 3/3] PM: Limit race conditions between runtime PM and system sleep Rafael J. Wysocki
2011-06-26  2:57   ` Alan Stern
2011-06-26 20:21     ` Rafael J. Wysocki
2011-06-28 15:56   ` Ming Lei
2011-06-28 21:42     ` Rafael J. Wysocki
2011-06-29 14:11       ` Alan Stern
2011-06-29 19:35         ` Rafael J. Wysocki
2011-07-01 16:22   ` Kevin Hilman
2011-07-01 19:50     ` Rafael J. Wysocki
2011-06-29 21:29 ` [PATCH 0/6 v2] PM: Fix up interactions between system suspend/resume and runtime PM Rafael J. Wysocki
2011-06-29 21:31   ` [PATCH 1/6 v2] PM / Runtime: Update documentation of interactions with system sleep Rafael J. Wysocki
2011-06-29 21:32   ` [PATCH 2/6 v2] PM / Runtime: Return special error code if runtime PM is disabled Rafael J. Wysocki
2011-06-29 21:33   ` [PATCH 3/6 v2] PCI / PM: Detect early wakeup in pci_pm_prepare() Rafael J. Wysocki
2011-06-29 21:34   ` [PATCH 4/6 v2] PM: Limit race conditions between runtime PM and system sleep (v2) Rafael J. Wysocki
2011-10-27 13:54     ` Linus Walleij
2011-10-27 20:06       ` Rafael J. Wysocki [this message]
2011-10-28 20:00         ` Linus Walleij
2011-11-02 19:14       ` Greg KH
2011-11-02 20:06         ` Linus Walleij
2011-11-02 20:11           ` Greg KH
2011-11-02 21:00             ` Linus Walleij
2011-11-02 21:17               ` Greg KH
2011-11-03  0:28                 ` Rafael J. Wysocki
2011-11-03  1:31                   ` Greg KH
2011-06-29 21:35   ` [PATCH 5/6 v2] PM / Runtime: Improve documentation of enable, disable and barrier Rafael J. Wysocki
2011-06-29 21:35   ` [PATCH 6/6 v2] PM / Runtime: Replace "run-time" with "runtime" in documentation Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201110272206.35180.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=greg@kroah.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=khilman@ti.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=stable@kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox