* [patch] drm/i915: fix if statement (bogus semi-colon)
@ 2011-10-28 11:42 Dan Carpenter
2011-10-28 17:10 ` Keith Packard
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2011-10-28 11:42 UTC (permalink / raw)
To: David Airlie; +Cc: linux-kernel, kernel-janitors
The semi-colon is a typo here and it makes the if statement
unconditional.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/char/agp/intel-gtt.c b/drivers/char/agp/intel-gtt.c
index 66cd0b8..3a8d448 100644
--- a/drivers/char/agp/intel-gtt.c
+++ b/drivers/char/agp/intel-gtt.c
@@ -1236,7 +1236,7 @@ static int i9xx_setup(void)
intel_private.gtt_bus_addr = reg_addr + gtt_offset;
}
- if (needs_idle_maps());
+ if (needs_idle_maps())
intel_private.base.do_idle_maps = 1;
intel_i9xx_setup_flush();
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] drm/i915: fix if statement (bogus semi-colon)
2011-10-28 11:42 [patch] drm/i915: fix if statement (bogus semi-colon) Dan Carpenter
@ 2011-10-28 17:10 ` Keith Packard
2011-10-28 17:20 ` Chris Wilson
0 siblings, 1 reply; 3+ messages in thread
From: Keith Packard @ 2011-10-28 17:10 UTC (permalink / raw)
To: Dan Carpenter, David Airlie; +Cc: linux-kernel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 205 bytes --]
On Fri, 28 Oct 2011 14:42:41 +0300, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> - if (needs_idle_maps());
> + if (needs_idle_maps())
how embarrassing is that?
--
keith.packard@intel.com
[-- Attachment #2: Type: application/pgp-signature, Size: 827 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] drm/i915: fix if statement (bogus semi-colon)
2011-10-28 17:10 ` Keith Packard
@ 2011-10-28 17:20 ` Chris Wilson
0 siblings, 0 replies; 3+ messages in thread
From: Chris Wilson @ 2011-10-28 17:20 UTC (permalink / raw)
To: Keith Packard, Dan Carpenter, David Airlie; +Cc: linux-kernel, kernel-janitors
On Fri, 28 Oct 2011 10:10:26 -0700, Keith Packard <keithp@keithp.com> wrote:
> On Fri, 28 Oct 2011 14:42:41 +0300, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> > - if (needs_idle_maps());
> > + if (needs_idle_maps())
>
> how embarrassing is that?
Actually it served an ulterior purpose and by exercising the workaround
showed us that it contained a more subtle bug. I believe therefore Ben
did it deliberately ;-)
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-28 17:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-28 11:42 [patch] drm/i915: fix if statement (bogus semi-colon) Dan Carpenter
2011-10-28 17:10 ` Keith Packard
2011-10-28 17:20 ` Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).