From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Mike Frysinger <vapier@gentoo.org>,
Linus Walleij <linus.walleij@linaro.org>
Cc: Sekhar Nori <nsekhar@ti.com>, Kevin Hilman <khilman@ti.com>,
Grant Likely <grant.likely@secretlab.ca>,
linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
davinci-linux-open-source@linux.davincidsp.com
Subject: Re: [PATCH] asm-generic/gpio.h: merge basic gpiolib wrappers
Date: Fri, 28 Oct 2011 13:42:00 +0100 [thread overview]
Message-ID: <20111028124200.GU19187@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAJaTeTp71t0BYsEpDu07BE5ox2FBAiH7xEQqjhb=6QadrsQGAQ@mail.gmail.com>
On Fri, Oct 28, 2011 at 02:15:00PM +0200, Mike Frysinger wrote:
> On Thu, Oct 27, 2011 at 15:11, Russell King - ARM Linux wrote:
> > This is extremely dangerous. Consider for example this code
> > (see ARM mach-davinci's gpio.h):
>
> it's interesting you highlight davinci. if i'm reading things
> correctly, the current davinci code is broken today and my v2 proposed
> patch actually fixes it.
That looks like an error in patch 5f3fcf9649dbb010ccac41259d04147775ec8fc2
(ARM: 7040/1: mach-davinci: break out GPIO driver specifics) which does
this:
-#define __ARM_GPIOLIB_COMPLEX
Linus, can you send a fix?
next prev parent reply other threads:[~2011-10-28 12:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 7:33 [PATCH] gpiolib/arches: Centralise bolierplate asm/gpio.h Mark Brown
2011-10-25 8:33 ` Grant Likely
2011-10-25 8:39 ` Mark Brown
2011-10-25 23:44 ` Mike Frysinger
2011-10-26 7:33 ` Mark Brown
2012-02-03 23:16 ` Grant Likely
2011-10-27 13:01 ` [PATCH] asm-generic/gpio.h: merge basic gpiolib wrappers Mike Frysinger
2011-10-27 16:24 ` Andreas Schwab
2011-10-27 22:52 ` [PATCH v2] " Mike Frysinger
[not found] ` <20111027131124.GK19187@n2100.arm.linux.org.uk>
2011-10-28 12:15 ` [PATCH] " Mike Frysinger
2011-10-28 12:42 ` Russell King - ARM Linux [this message]
2011-10-28 13:51 ` Linus Walleij
2011-10-28 14:04 ` Mike Frysinger
2011-11-03 3:45 ` [PATCH v3] " Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111028124200.GU19187@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=grant.likely@secretlab.ca \
--cc=khilman@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).