* [RFC][PATCH v2 -next 1/2] Move kmsg_dump(KMSG_DUMP_PANIC) below smp_send_stop()
@ 2011-10-21 21:20 Seiji Aguchi
2011-10-28 18:27 ` Don Zickus
0 siblings, 1 reply; 2+ messages in thread
From: Seiji Aguchi @ 2011-10-21 21:20 UTC (permalink / raw)
To: Andrew Morton, Chen, Gong, linux-kernel@vger.kernel.org,
Luck, Tony, Matthew Garrett, Vivek Goyal, len.brown@intel.com,
ying.huang@intel.com, ak@linux.intel.com, hughd@chromium.org,
mingo@elte.hu, jmorris@namei.org, a.p.zijlstra@chello.nl,
namhyung@gmail.com, Don Zickus
Cc: dle-develop@lists.sourceforge.net, Satoru Moriya
This patch is just moving kmsg_dump(KMSG_DUMP_PANIC) below smp_send_stop
for serializing logging process via smp_send_stop.
Signed-off-by: Seiji Aguchi <seiji.aguchi@hds.com>
---
kernel/panic.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/panic.c b/kernel/panic.c
index d7bb697..41bf6ad 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -88,8 +88,6 @@ NORET_TYPE void panic(const char * fmt, ...)
*/
crash_kexec(NULL);
- kmsg_dump(KMSG_DUMP_PANIC);
-
/*
* Note smp_send_stop is the usual smp shutdown function, which
* unfortunately means it may not be hardened to work in a panic
@@ -97,6 +95,8 @@ NORET_TYPE void panic(const char * fmt, ...)
*/
smp_send_stop();
+ kmsg_dump(KMSG_DUMP_PANIC);
+
atomic_notifier_call_chain(&panic_notifier_list, 0, buf);
bust_spinlocks(0);
-- 1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFC][PATCH v2 -next 1/2] Move kmsg_dump(KMSG_DUMP_PANIC) below smp_send_stop()
2011-10-21 21:20 [RFC][PATCH v2 -next 1/2] Move kmsg_dump(KMSG_DUMP_PANIC) below smp_send_stop() Seiji Aguchi
@ 2011-10-28 18:27 ` Don Zickus
0 siblings, 0 replies; 2+ messages in thread
From: Don Zickus @ 2011-10-28 18:27 UTC (permalink / raw)
To: Seiji Aguchi
Cc: Andrew Morton, Chen, Gong, linux-kernel@vger.kernel.org,
Luck, Tony, Matthew Garrett, Vivek Goyal, len.brown@intel.com,
ying.huang@intel.com, ak@linux.intel.com, hughd@chromium.org,
mingo@elte.hu, jmorris@namei.org, a.p.zijlstra@chello.nl,
namhyung@gmail.com, dle-develop@lists.sourceforge.net,
Satoru Moriya
On Fri, Oct 21, 2011 at 05:20:07PM -0400, Seiji Aguchi wrote:
> This patch is just moving kmsg_dump(KMSG_DUMP_PANIC) below smp_send_stop
> for serializing logging process via smp_send_stop.
I feel it is good to always serialize the logging when we are panic'ing.
So this patch is a step in the right direction.
Acked-by: Don Zickus <dzickus@redhat.com>
>
> Signed-off-by: Seiji Aguchi <seiji.aguchi@hds.com>
>
> ---
> kernel/panic.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/panic.c b/kernel/panic.c
> index d7bb697..41bf6ad 100644
> --- a/kernel/panic.c
> +++ b/kernel/panic.c
> @@ -88,8 +88,6 @@ NORET_TYPE void panic(const char * fmt, ...)
> */
> crash_kexec(NULL);
>
> - kmsg_dump(KMSG_DUMP_PANIC);
> -
> /*
> * Note smp_send_stop is the usual smp shutdown function, which
> * unfortunately means it may not be hardened to work in a panic
> @@ -97,6 +95,8 @@ NORET_TYPE void panic(const char * fmt, ...)
> */
> smp_send_stop();
>
> + kmsg_dump(KMSG_DUMP_PANIC);
> +
> atomic_notifier_call_chain(&panic_notifier_list, 0, buf);
>
> bust_spinlocks(0);
> -- 1.7.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-28 18:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-21 21:20 [RFC][PATCH v2 -next 1/2] Move kmsg_dump(KMSG_DUMP_PANIC) below smp_send_stop() Seiji Aguchi
2011-10-28 18:27 ` Don Zickus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).