public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk@arm.linux.org.uk>
To: Jeff Garzik <jeff@garzik.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	linus.walleij@linaro.org, swarren@nvidia.com,
	Olof Johansson <olof@lixom.net>,
	Ben Hutchings <ben@decadent.org.uk>,
	"Arnaud Patard (Rtp)" <arnaud.patard@rtp-net.org>,
	Grant Likely <grant.likely@secretlab.ca>,
	Wolfram Sang <w.sang@pengutronix.de>,
	bs14@csr.com
Subject: Re: Zero-length ARM headers in git HEAD
Date: Fri, 28 Oct 2011 21:37:37 +0100	[thread overview]
Message-ID: <20111028203737.GA914@flint.arm.linux.org.uk> (raw)
In-Reply-To: <4EAB0772.40404@garzik.org>

On Fri, Oct 28, 2011 at 03:50:10PM -0400, Jeff Garzik wrote:
> Gents,
>
> In the following kernel commits,
>
> 	9c587c05d715ca8461342c2cb3b4a67036b5c22b
> 	ea5abbd215b749b2ff14397a47a5e65741c67bf4
> 	cc890cd78acd7ab03442907d354b6af34e973cb3
>
> the file ...$platform/mach/gpio.h is replaced with an empty file.  This  
> disagrees with kernel tradition and kernel makefiles, where zero length  
> files are intentionally deleted when "make distclean" is executed.

It would really help to have a hook in git which catches this at commit
time with a warning (like is possible for whitespace).  At least that
would alert folk to the problem at commit time before stuff has been
published.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:

      parent reply	other threads:[~2011-10-28 20:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-28 19:50 Zero-length ARM headers in git HEAD Jeff Garzik
2011-10-28 20:09 ` Linus Walleij
2011-10-28 20:37 ` Russell King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111028203737.GA914@flint.arm.linux.org.uk \
    --to=rmk@arm.linux.org.uk \
    --cc=arnaud.patard@rtp-net.org \
    --cc=ben@decadent.org.uk \
    --cc=bs14@csr.com \
    --cc=grant.likely@secretlab.ca \
    --cc=jeff@garzik.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=swarren@nvidia.com \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox