From: Grant Likely <grant.likely@secretlab.ca>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] gpio: pca953x: remove unneeded check for chip type
Date: Sat, 29 Oct 2011 12:26:46 +0200 [thread overview]
Message-ID: <20111029102646.GA20132@ponder.secretlab.ca> (raw)
In-Reply-To: <20111029065820.GA2111@pengutronix.de>
On Sat, Oct 29, 2011 at 08:58:20AM +0200, Wolfram Sang wrote:
> On Fri, Oct 14, 2011 at 03:31:59PM +0200, Wolfram Sang wrote:
> > We can assume our own device_id table is correct, so remove checking if
> > the chip type is valid. (The check was bogus anyway: If it found an
> > invalid entry, it returned with 0!) This is in preparation for further
> > cleanups.
> >
> > Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> > Cc: Grant Likely <grant.likely@secretlab.ca>
>
> Ping for this mini-series.
Merged and I'll push out for 3.2, thanks.
g.
>
> > ---
> > drivers/gpio/gpio-pca953x.c | 4 +---
> > 1 files changed, 1 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> > index c43b8ff..45de6a4 100644
> > --- a/drivers/gpio/gpio-pca953x.c
> > +++ b/drivers/gpio/gpio-pca953x.c
> > @@ -673,10 +673,8 @@ static int __devinit pca953x_probe(struct i2c_client *client,
> >
> > if (chip->chip_type == PCA953X_TYPE)
> > device_pca953x_init(chip, invert);
> > - else if (chip->chip_type == PCA957X_TYPE)
> > - device_pca957x_init(chip, invert);
> > else
> > - goto out_failed;
> > + device_pca957x_init(chip, invert);
> >
> > ret = pca953x_irq_setup(chip, id, irq_base);
> > if (ret)
> > --
> > 1.7.6.3
> >
>
> --
> Pengutronix e.K. | Wolfram Sang |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
prev parent reply other threads:[~2011-10-29 10:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 13:31 [PATCH 1/2] gpio: pca953x: remove unneeded check for chip type Wolfram Sang
2011-10-14 13:32 ` [PATCH 2/2] gpio: pca953x: propagate the errno from the chip_init functions Wolfram Sang
2011-10-29 6:58 ` [PATCH 1/2] gpio: pca953x: remove unneeded check for chip type Wolfram Sang
2011-10-29 10:26 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111029102646.GA20132@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox