linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Matthijs Kooijman <matthijs@stdin.nl>
Cc: Gaudenz Steinlin <gaudenz@debian.org>,
	linux-kernel@vger.kernel.org,
	Jameson Graef Rollins <jrollins@finestructure.net>,
	Jonathan Nieder <jrnieder@gmail.com>,
	Jens Axboe <axboe@kernel.dk>, Amit Shah <amit.shah@redhat.com>,
	David Zeuthen <zeuthen@gmail.com>,
	Martin Pitt <martin.pitt@ubuntu.com>
Subject: Re: [regression] CD-ROM polling blocks suspend on some machines (Re: [PATCH 1/2] cdrom: always check_disk_change() on open)
Date: Sun, 30 Oct 2011 13:35:03 -0700	[thread overview]
Message-ID: <20111030203503.GB7696@google.com> (raw)
In-Reply-To: <20111028134743.GU14392@login.drsnuggles.stderr.nl>

Hello,

On Fri, Oct 28, 2011 at 03:47:43PM +0200, Matthijs Kooijman wrote:
> I'm not sure if the FRAME_POINTER option actually works, though, since I
> couldn't find any obvious differences in the format of the stack traces?

The lines w/o leading "?" are from stack frames discovered by
following frame pointer.  The ones w/ "?" are from dumb stack
scanning.  w/o FP, it wouldn't be possible to tell between the actual
ones from the spurious ones.

So, the following kworker is what the scsi_id is waiting for in
flush_work().

 kworker/2:1     D ffff880206054830     0 10775      2 0x00000000
  ffff880206067aa0 0000000000000046 ffff880206067a50 ffffffff8105476d
  ffff88022ed58140 ffff880206067fd8 ffff880206067fd8 0000000000012f40
  ffff880206054830 ffff88022ed58140 ffff880200000002 0000000000000286
 Call Trace:
  [<ffffffff8134c996>] schedule+0x55/0x57
  [<ffffffff8134cc9f>] schedule_timeout+0xa2/0xd9
  [<ffffffff8134c832>] wait_for_common+0x9e/0x115
  [<ffffffff8134c925>] wait_for_completion_timeout+0xe/0x10
  [<ffffffff8119c502>] blk_execute_rq+0xb7/0xf9
  [<ffffffffa0043044>] scsi_execute+0xf5/0x14d [scsi_mod]
  [<ffffffffa004311e>] scsi_execute_req+0x82/0xb4 [scsi_mod]
  [<ffffffffa00bb2d9>] sr_check_events+0x92/0x21e [sr_mod]
  [<ffffffffa009d04b>] cdrom_check_events+0x14/0x29 [cdrom]
  [<ffffffffa00bb696>] sr_block_check_events+0x14/0x16 [sr_mod]
  [<ffffffff8119ea7b>] disk_events_workfn+0x3b/0xd7
  [<ffffffff8105dcc9>] process_one_work+0x165/0x27a
  [<ffffffff8105ed4f>] worker_thread+0xce/0x152
  [<ffffffff81061f6c>] kthread+0x7f/0x87
  [<ffffffff81355034>] kernel_thread_helper+0x4/0x10

The kworker submitted request but it got lost during queue destruction
and blk_execute_rq() hangs.  There have been a number of recent
changes in block devel tree to address this issue.  Can you please
test the following branch?

 git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git block-ref

Thanks.

-- 
tejun

  reply	other threads:[~2011-10-30 20:35 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-06 12:20 [PATCH 1/2] cdrom: always check_disk_change() on open Tejun Heo
2011-04-06 12:22 ` [PATCH 2/2] block: rescan partitions on invalidated devices on -ENOMEDIA too Tejun Heo
2011-04-29  6:57 ` [PATCH 1/2] cdrom: always check_disk_change() on open Amit Shah
2011-04-29  8:15   ` Tejun Heo
2011-04-29  8:15   ` Jens Axboe
2011-04-29  8:16     ` Tejun Heo
2011-04-29  8:28       ` Jens Axboe
2011-05-10  6:42     ` Amit Shah
2011-05-10  7:44       ` Jens Axboe
2011-05-10  8:13         ` Amit Shah
2011-09-03 22:14 ` [regression] CD-ROM polling blocks suspend on some machines (Re: [PATCH 1/2] cdrom: always check_disk_change() on open) Jonathan Nieder
2011-09-04  2:42   ` Tejun Heo
2011-09-04 15:05     ` [regression] CD-ROM polling blocks suspend on some machines Jonathan Nieder
2011-09-05  1:49     ` [regression] CD-ROM polling blocks suspend on some machines (Re: [PATCH 1/2] cdrom: always check_disk_change() on open) Jameson Graef Rollins
2011-09-06 17:45       ` Tejun Heo
2011-09-07  8:50         ` Matthijs Kooijman
2011-09-11  4:08           ` Tejun Heo
2011-10-24 20:25             ` Gaudenz Steinlin
2011-10-26 18:26               ` Matthijs Kooijman - Brevidius
2011-10-26 22:25                 ` Tejun Heo
2011-10-28 13:47                   ` Matthijs Kooijman
2011-10-30 20:35                     ` Tejun Heo [this message]
2011-10-31  9:28                       ` Matthijs Kooijman
2011-10-31 15:26                         ` Tejun Heo
2011-12-19 11:12                           ` Matthijs Kooijman
2011-12-19 16:44                             ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111030203503.GB7696@google.com \
    --to=tj@kernel.org \
    --cc=amit.shah@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=gaudenz@debian.org \
    --cc=jrnieder@gmail.com \
    --cc=jrollins@finestructure.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.pitt@ubuntu.com \
    --cc=matthijs@stdin.nl \
    --cc=zeuthen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).