From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Wu Fengguang <fengguang.wu@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>, Lai Jiangshan <laijs@cn.fujitsu.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Carsten Emde <cbe@osadl.org>
Subject: Re: linux-next 20111025: warnings in rcu_idle_exit_common()/rcu_idle_enter_common()
Date: Wed, 2 Nov 2011 08:14:26 -0700 [thread overview]
Message-ID: <20111102151426.GN2287@linux.vnet.ibm.com> (raw)
In-Reply-To: <1320245786.4793.32.camel@gandalf.stny.rr.com>
On Wed, Nov 02, 2011 at 10:56:26AM -0400, Steven Rostedt wrote:
> On Wed, 2011-11-02 at 07:44 -0700, Paul E. McKenney wrote:
>
> > rcu: Fix idle-task checks
> >
> > RCU has traditionally relied on idle_cpu() to determine whether a given
> > CPU is running in the context of an idle task, but recent changes have
> > invalidated this approach.
>
> Correct. idle_cpu() returns if the CPU is idle or not, not if the CPU is
> running the idle thread. If the CPU wakes up on the idle thread and
> there's tasks on the run queue, then idle_cpu() will return false, even
> though the task running is the idle thread. But the CPU itself is not
> technically idle.
>
> Acked-by: Steven Rostedt <rostedt@goodmis.org>
Thank you, Steven! I have added your Acked-by.
Thanx, Paul
next prev parent reply other threads:[~2011-11-02 15:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 8:26 linux-next 20111025: warnings in rcu_idle_exit_common()/rcu_idle_enter_common() Wu Fengguang
2011-10-31 9:51 ` Paul E. McKenney
2011-10-31 10:43 ` Wu Fengguang
2011-10-31 11:41 ` Wu Fengguang
2011-10-31 12:19 ` Paul E. McKenney
2011-10-31 15:44 ` Steven Rostedt
2011-11-01 0:34 ` Paul E. McKenney
2011-11-01 7:07 ` Wu Fengguang
2011-11-01 14:36 ` Carsten Emde
2011-11-01 15:03 ` Paul E. McKenney
2011-11-01 16:00 ` Paul E. McKenney
2011-11-01 16:32 ` Wu Fengguang
2011-11-02 14:44 ` Paul E. McKenney
2011-11-02 14:51 ` Steven Rostedt
2011-11-02 15:14 ` Paul E. McKenney
2011-11-02 15:43 ` Steven Rostedt
2011-11-03 16:09 ` Paul E. McKenney
2011-11-02 14:56 ` Steven Rostedt
2011-11-02 15:01 ` Wu Fengguang
2011-11-02 15:14 ` Paul E. McKenney
2011-11-02 15:14 ` Paul E. McKenney [this message]
2011-10-31 12:31 ` Wu Fengguang
[not found] ` <20111031123708.GA6839@localhost>
2011-10-31 22:14 ` Paul E. McKenney
2011-11-10 16:35 ` Peter Zijlstra
2011-11-10 17:20 ` Paul E. McKenney
2011-11-10 18:33 ` Peter Zijlstra
2011-11-01 17:34 ` Frederic Weisbecker
2011-11-01 18:36 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111102151426.GN2287@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=cbe@osadl.org \
--cc=fengguang.wu@intel.com \
--cc=fweisbec@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox