From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933562Ab1KBQgO (ORCPT ); Wed, 2 Nov 2011 12:36:14 -0400 Received: from zene.cmpxchg.org ([85.214.230.12]:42917 "EHLO zene.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933171Ab1KBQgN (ORCPT ); Wed, 2 Nov 2011 12:36:13 -0400 Date: Wed, 2 Nov 2011 17:35:27 +0100 From: Johannes Weiner To: Johannes Weiner Cc: Konstantin Khlebnikov , Pekka Enberg , "linux-mm@kvack.org" , Andrew Morton , "linux-kernel@vger.kernel.org" , Wu Fengguang , KAMEZAWA Hiroyuki , Rik van Riel , Mel Gorman , Minchan Kim , Gene Heskett Subject: Re: [PATCH 1/2] vmscan: promote shared file mapped pages Message-ID: <20111102163527.GK19965@cmpxchg.org> References: <20110808110658.31053.55013.stgit@localhost6> <4E3FD403.6000400@parallels.com> <20111102163056.GG19965@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111102163056.GG19965@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 02, 2011 at 05:30:56PM +0100, Johannes Weiner wrote: > Tipping the balance for inactive list rotation has been there from the > beginning, but I don't quite understand why. It probably was not a > problem as the conditions for inactive cycling applied to both file > and anon equally, but with used-once detection for file and deferred > file writeback from direct reclaim, we tend to cycle more file pages > on the inactive list than anonymous ones. Those rotated pages should > be a signal to favor file reclaim, though. [...] should NOT be a signal [...] obviously. Sorry.