[PATCH] mmc: omap_hsmmc: Fix build for hsmmc

[PATCH] mmc: omap_hsmmc: Fix build for hsmmc

[Tony Lindgren]

Commit a3c76eb9d4a1e68a69dd880cf0bcb8a52418b993 (mmc: replace
printk with appropriate display macro) does not compile:

drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_protect_card':
drivers/mmc/host/omap_hsmmc.c:1273: error: 'pr_info' undeclared (first use in this function)
drivers/mmc/host/omap_hsmmc.c:1273: error: (Each undeclared identifier is reported only once
drivers/mmc/host/omap_hsmmc.c:1273: error: for each function it appears in.)
drivers/mmc/host/omap_hsmmc.c:1273: error: expected ';' before string constant
drivers/mmc/host/omap_hsmmc.c:1275: error: expected statement before ')' token
distcc[15197] ERROR: compile drivers/mmc/host/omap_hsmmc.c on localhost failed

Cc: Girish K S <girish.shivananjappa@linaro.org>
Cc: Chris Ball <cjb@laptop.org>
Cc: linux-mmc@vger.kernel.org
Signed-off-by: Tony Lindgren <tony@atomide.com>

--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -1270,7 +1270,7 @@ static void omap_hsmmc_protect_card(struct omap_hsmmc_host *host)
 		}
 	} else {
 		if (!host->protect_card) {
-			pr_info"%s: cover is open, "
+			pr_info("%s: cover is open, "
 					 "card is now inaccessible\n",
 					 mmc_hostname(host->mmc));
 			host->protect_card = 1;

Re: [PATCH] mmc: omap_hsmmc: Fix build for hsmmc

[Thomas Weber]

Hello Tony, hello
Chris,https://mail.google.com/mail/?shva=1#label/linux-omap/133653efb30ae047

isn't this already fixed?

http://marc.info/?l=linux-omap&m=131991921316862&w=2

[PATCH] omap_hsmmc: fix missing parenthesis in pr_info

Thomas

On Wed, Nov 2, 2011 at 6:06 PM, Tony Lindgren <tony@atomide.com> wrote:
> Commit a3c76eb9d4a1e68a69dd880cf0bcb8a52418b993 (mmc: replace
> printk with appropriate display macro) does not compile:
>
> drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_protect_card':
> drivers/mmc/host/omap_hsmmc.c:1273: error: 'pr_info' undeclared (first use in this function)
> drivers/mmc/host/omap_hsmmc.c:1273: error: (Each undeclared identifier is reported only once
> drivers/mmc/host/omap_hsmmc.c:1273: error: for each function it appears in.)
> drivers/mmc/host/omap_hsmmc.c:1273: error: expected ';' before string constant
> drivers/mmc/host/omap_hsmmc.c:1275: error: expected statement before ')' token
> distcc[15197] ERROR: compile drivers/mmc/host/omap_hsmmc.c on localhost failed
>
> Cc: Girish K S <girish.shivananjappa@linaro.org>
> Cc: Chris Ball <cjb@laptop.org>
> Cc: linux-mmc@vger.kernel.org
> Signed-off-by: Tony Lindgren <tony@atomide.com>
>
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -1270,7 +1270,7 @@ static void omap_hsmmc_protect_card(struct omap_hsmmc_host *host)
>                }
>        } else {
>                if (!host->protect_card) {
> -                       pr_info"%s: cover is open, "
> +                       pr_info("%s: cover is open, "
>                                         "card is now inaccessible\n",
>                                         mmc_hostname(host->mmc));
>                        host->protect_card = 1;
>

Re: [PATCH] mmc: omap_hsmmc: Fix build for hsmmc

[Tony Lindgren]

* Thomas Weber <thomas.weber.linux@googlemail.com> [111102 11:22]:
> Hello Tony, hello
> Chris,https://mail.google.com/mail/?shva=1#label/linux-omap/133653efb30ae047
> 
> isn't this already fixed?
> 
> http://marc.info/?l=linux-omap&m=131991921316862&w=2
> 
> [PATCH] omap_hsmmc: fix missing parenthesis in pr_info

Heh looks like this is actually the third fix to this posted :)
I'm happy with the first one thanks.

Tony