From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932858Ab1KCHuM (ORCPT ); Thu, 3 Nov 2011 03:50:12 -0400 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:55751 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932075Ab1KCHuJ (ORCPT ); Thu, 3 Nov 2011 03:50:09 -0400 Date: Thu, 3 Nov 2011 03:50:07 -0400 From: Christoph Hellwig To: Rusty Russell Cc: MichaelS.Tsirkist@redhat.com, Christoph Hellwig , virtualization , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2 of 5] virtio: rename virtqueue_add_buf_gfp to virtqueue_add_buf Message-ID: <20111103075007.GC6993@infradead.org> References: <07aa6e8fcfc2bcba854e.1320306170@localhost6.localdomain6> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <07aa6e8fcfc2bcba854e.1320306170@localhost6.localdomain6> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 03, 2011 at 06:12:50PM +1030, Rusty Russell wrote: > Remove wrapper functions. This makes the allocation type explicit in > all callers; I used GPF_KERNEL where it seemed obvious, left it at > GFP_ATOMIC otherwise. Looks good, Reviewed-by: Christoph Hellwig