From: Mike Frysinger <vapier@gentoo.org>
To: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Paul Mundt <lethal@linux-sh.org>,
Magnus Damm <magnus.damm@gmail.com>,
Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>,
Linus Walleij <linus.walleij@stericsson.com>,
Kukjin Kim <kgene.kim@samsung.com>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
David Brown <davidb@codeaurora.org>,
Rabin Vincent <rabin.vincent@stericsson.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH 0/3] Change ARCH_NR_GPIO into a Kconfig variable
Date: Thu, 3 Nov 2011 18:16:33 -0400 [thread overview]
Message-ID: <201111031816.37427.vapier@gentoo.org> (raw)
In-Reply-To: <1320339647-30255-1-git-send-email-pdeschrijver@nvidia.com>
[-- Attachment #1: Type: Text/Plain, Size: 976 bytes --]
On Thursday 03 November 2011 13:00:44 Peter De Schrijver wrote:
> This patchset converts ARCH_NR_GPIO to a Kconfig variable as suggested by
> Russel King. It also converts some platforms to the new model.
>
> Peter De Schrijver (3):
> ARM: ARCH_NR_GPIO: Make ARCH_NR_GPIO a Kconfig variable
> ARM: mach-shmobile: Use CONFIG_ARCH_NR_GPIO
> ARM: mach-ux500 Use CONFIG_ARCH_NR_GPIO
>
> arch/arm/Kconfig | 10 ++++++++++
> arch/arm/include/asm/gpio.h | 4 ++++
> arch/arm/mach-shmobile/include/mach/gpio.h | 2 --
> arch/arm/mach-ux500/include/mach/gpio.h | 5 -----
> 4 files changed, 14 insertions(+), 7 deletions(-)
i'm not sure how this is an improvement. we go from declaring the define in
the right mach-specific subdir (arch/arm/mach-xxx/include/mach/gpio.h) to an
arm-global file (arm/Kconfig). i'd think the ideal would be to keep all the
mach cruft in the mach-xxx/ subdir.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-11-03 22:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-03 17:00 [PATCH 0/3] Change ARCH_NR_GPIO into a Kconfig variable Peter De Schrijver
2011-11-03 17:00 ` [PATCH 1/3] ARM: ARCH_NR_GPIO: Make ARCH_NR_GPIO " Peter De Schrijver
2011-11-03 17:00 ` [PATCH 2/3] ARM: mach-shmobile: Use CONFIG_ARCH_NR_GPIO Peter De Schrijver
2011-11-03 17:00 ` [PATCH 3/3] ARM: mach-ux500 " Peter De Schrijver
2011-11-03 22:16 ` Mike Frysinger [this message]
2011-11-03 22:44 ` [PATCH 0/3] Change ARCH_NR_GPIO into a Kconfig variable Russell King - ARM Linux
2011-11-03 23:07 ` Mike Frysinger
2011-11-03 23:12 ` Mike Frysinger
2011-11-03 23:17 ` Russell King - ARM Linux
2011-11-04 2:05 ` Mike Frysinger
2011-11-29 6:46 ` Peter De Schrijver
2011-11-29 8:40 ` Linus Walleij
2011-11-29 9:15 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111031816.37427.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=davidb@codeaurora.org \
--cc=hsweeten@visionengravers.com \
--cc=kgene.kim@samsung.com \
--cc=lethal@linux-sh.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=pdeschrijver@nvidia.com \
--cc=rabin.vincent@stericsson.com \
--cc=srinidhi.kasagar@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox