* REGRESSION: "perf: Add PM notifiers ..." breaks resume
@ 2011-11-02 13:49 Andi Kleen
2011-11-03 0:00 ` Linus Torvalds
0 siblings, 1 reply; 6+ messages in thread
From: Andi Kleen @ 2011-11-02 13:49 UTC (permalink / raw)
To: Peter Zijlstra; +Cc: mingo, torvalds, linux-kernel, rjw
Resume stopped working on my Acer Aspire 1830T post 3.1. The screen
just stays black after wakeup.
I bisected it down to
commit 144060fee07e9c22e179d00819c83c86fbcbf82c
Author: Peter Zijlstra <a.p.zijlstra@chello.nl>
Date: Mon Aug 1 12:49:14 2011 +0200
perf: Add PM notifiers to fix CPU hotplug races
Reverting this patch fixes the problem for me.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: REGRESSION: "perf: Add PM notifiers ..." breaks resume
2011-11-02 13:49 REGRESSION: "perf: Add PM notifiers ..." breaks resume Andi Kleen
@ 2011-11-03 0:00 ` Linus Torvalds
2011-11-03 7:37 ` Ingo Molnar
2011-11-06 19:57 ` Peter Zijlstra
0 siblings, 2 replies; 6+ messages in thread
From: Linus Torvalds @ 2011-11-03 0:00 UTC (permalink / raw)
To: Andi Kleen; +Cc: Peter Zijlstra, mingo, linux-kernel, rjw
Peter, Ingo, ping?
Quite frankly, I'm inclined to revert that patch just for being
horribly ugly and apparently broken regardless of the fact that it
also causes a regression.
*Notifiers* for doing something like this? smp_call_function? That's
just utter sh*t, guys.
If it is CPU state, then it should damn well be suspended and resumed
as part of CPU suspend and resume. No IPI cross-calls to ask other
CPU's to do random work, no crap like that.
Comments? Should I just revert the thing (silence is obviously "yes"
in cases like this where we are talking about regressions anyway)?
Linus
On Wed, Nov 2, 2011 at 6:49 AM, Andi Kleen <andi@firstfloor.org> wrote:
>
> Resume stopped working on my Acer Aspire 1830T post 3.1. The screen
> just stays black after wakeup.
>
> I bisected it down to
>
> commit 144060fee07e9c22e179d00819c83c86fbcbf82c
> Author: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Date: Mon Aug 1 12:49:14 2011 +0200
>
> perf: Add PM notifiers to fix CPU hotplug races
>
> Reverting this patch fixes the problem for me.
>
> -Andi
>
> --
> ak@linux.intel.com -- Speaking for myself only.
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: REGRESSION: "perf: Add PM notifiers ..." breaks resume
2011-11-03 0:00 ` Linus Torvalds
@ 2011-11-03 7:37 ` Ingo Molnar
2011-11-03 14:44 ` Linus Torvalds
2011-11-06 19:57 ` Peter Zijlstra
1 sibling, 1 reply; 6+ messages in thread
From: Ingo Molnar @ 2011-11-03 7:37 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Andi Kleen, Peter Zijlstra, linux-kernel, rjw
* Linus Torvalds <torvalds@linux-foundation.org> wrote:
> Peter, Ingo, ping?
>
> Quite frankly, I'm inclined to revert that patch just for being
> horribly ugly and apparently broken regardless of the fact that it
> also causes a regression.
>
> *Notifiers* for doing something like this? smp_call_function?
> That's just utter sh*t, guys.
>
> If it is CPU state, then it should damn well be suspended and
> resumed as part of CPU suspend and resume. No IPI cross-calls to
> ask other CPU's to do random work, no crap like that.
Agreed, that's quite crappy.
> Comments? Should I just revert the thing (silence is obviously
> "yes" in cases like this where we are talking about regressions
> anyway)?
Yep, please revert it until we do the right fix. (I can queue up the
revert too)
Thanks,
Ingo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: REGRESSION: "perf: Add PM notifiers ..." breaks resume
2011-11-03 7:37 ` Ingo Molnar
@ 2011-11-03 14:44 ` Linus Torvalds
2011-11-03 19:46 ` Ingo Molnar
0 siblings, 1 reply; 6+ messages in thread
From: Linus Torvalds @ 2011-11-03 14:44 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Andi Kleen, Peter Zijlstra, linux-kernel, rjw
On Thu, Nov 3, 2011 at 12:37 AM, Ingo Molnar <mingo@elte.hu> wrote:
>
> Yep, please revert it until we do the right fix. (I can queue up the
> revert too)
Reverted,
Linus
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: REGRESSION: "perf: Add PM notifiers ..." breaks resume
2011-11-03 14:44 ` Linus Torvalds
@ 2011-11-03 19:46 ` Ingo Molnar
0 siblings, 0 replies; 6+ messages in thread
From: Ingo Molnar @ 2011-11-03 19:46 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Andi Kleen, Peter Zijlstra, linux-kernel, rjw
* Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Thu, Nov 3, 2011 at 12:37 AM, Ingo Molnar <mingo@elte.hu> wrote:
> >
> > Yep, please revert it until we do the right fix. (I can queue up the
> > revert too)
>
> Reverted,
Thanks!
Ingo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: REGRESSION: "perf: Add PM notifiers ..." breaks resume
2011-11-03 0:00 ` Linus Torvalds
2011-11-03 7:37 ` Ingo Molnar
@ 2011-11-06 19:57 ` Peter Zijlstra
1 sibling, 0 replies; 6+ messages in thread
From: Peter Zijlstra @ 2011-11-06 19:57 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Andi Kleen, mingo, linux-kernel, rjw
On Wed, 2011-11-02 at 17:00 -0700, Linus Torvalds wrote:
> Peter, Ingo, ping?
>
>
Shoot it.. I'll poke at it later and try and solve the thing
differently.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-11-06 19:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-02 13:49 REGRESSION: "perf: Add PM notifiers ..." breaks resume Andi Kleen
2011-11-03 0:00 ` Linus Torvalds
2011-11-03 7:37 ` Ingo Molnar
2011-11-03 14:44 ` Linus Torvalds
2011-11-03 19:46 ` Ingo Molnar
2011-11-06 19:57 ` Peter Zijlstra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox