Re: [PATCH block/for-next] block: don't call blk_drain_queue() if elevator is not up

Jens Axboe
2011-11-04T14:28:25Z

On 2011-11-04 15:26, Tejun Heo wrote:
> Hello,
>
> On Fri, Nov 4, 2011 at 1:12 AM, Jens Axboe <axboe@kernel.dk> wrote:
>>> Heh, yeah, definitely, and just to be paranoid, this whole thing is
>>> for the next merge window.
>>
>> Ehm, what parts? If the bug is in for-next, things are queued up for
>> _this_ merge window.
>
> So, we had four patchsets - the original drain improvements, updates
> to drain improvements, cfq locking cleanup, and cfq api cleanup.
> Currently, the first one is in block tree but the other three are not.
> I was thinking all four were going mainline in the next merge window.
>
> Hmmm... yeah, the first and second patchsets kinda go together but
> well the first one definitely is pretty good bug fix without others,
> so I guess that split isn't too bad either. Alright, no objection.

OK, I'll push off what I have now and then we can queue #2 up shortly. I
would probably prefer pushing the cfq locking cleanup to 3.3 to get some
more testing time on that, but it all depends on what your level of
confidence in it is?

--
Jens Axboe