From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755940Ab1KDQS7 (ORCPT ); Fri, 4 Nov 2011 12:18:59 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:33284 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753076Ab1KDQS6 (ORCPT ); Fri, 4 Nov 2011 12:18:58 -0400 Date: Fri, 4 Nov 2011 16:18:56 +0000 From: Mark Brown To: "Mohammed, Afzal" Cc: "linux-kernel@vger.kernel.org" , "Girdwood, Liam" , "sameo@linux.intel.com" , "Nori, Sekhar" , "linux-omap@vger.kernel.org" , "gg@slimlogic.co.uk" , Jorge Eduardo Candelaria Subject: Re: [PATCH 2/2] regulator:TPS65910: VDD1/2 voltage selector count Message-ID: <20111104161855.GC28902@opensource.wolfsonmicro.com> References: <1320410928-20349-1-git-send-email-afzal@ti.com> <20111104140422.GA28615@opensource.wolfsonmicro.com> <20111104152559.GC28615@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Cookie: A is for Apple. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 04, 2011 at 04:01:04PM +0000, Mohammed, Afzal wrote: > On Fri, Nov 04, 2011 at 20:55:59, Mark Brown wrote: > > That doesn't really clarify things - the question is why the number of > > voltages we can set is three times a constant called _NUM_VOLTS? > _NUM_VOLTS is the number of voltage steps. > I will try to come up with a better explanation or rather the > right solution, new to regulator world as of now. So that definitely seems wrong then - n_voltages is supposed to be the number of voltages that can be selected so if the regulator supports _NUM_VOLTS steps then I'd expect to see that constant used directly. Otherwise I'd suggest that the magic number needs a #define.