From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH v2 RESEND] ASoC: wm9081: Use snd_soc_update_bits for read-modify-write
Date: Fri, 4 Nov 2011 22:17:31 +0000 [thread overview]
Message-ID: <20111104221730.GA16978@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1318993587.7128.7.camel@phoenix>
On Wed, Oct 19, 2011 at 11:06:27AM +0800, Axel Lin wrote:
> /* Normal bias enable & soft start off */
> - reg |= WM9081_BIAS_ENA;
> - reg &= ~WM9081_VMID_RAMP;
> - snd_soc_write(codec, WM9081_VMID_CONTROL, reg);
> + snd_soc_update_bits(codec, WM9081_VMID_CONTROL,
> + WM9081_VMID_RAMP | WM9081_BIAS_ENA |
> + WM9081_VMID_SEL_MASK,
> + WM9081_BIAS_ENA);
This looks (and sounds) wrong - the original code didn't touch
VMID_SEL_MASK for this update but the new version will clear
VMID_SEL_MASK. Even with that fixed there still seems to be some issue
here, though.
next prev parent reply other threads:[~2011-11-04 22:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 3:06 [PATCH v2 RESEND] ASoC: wm9081: Use snd_soc_update_bits for read-modify-write Axel Lin
2011-10-19 8:10 ` Girdwood, Liam
2011-11-04 22:17 ` Mark Brown [this message]
2011-11-05 6:46 ` Axel Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111104221730.GA16978@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox