From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Jonas Gorski <jonas.gorski@gmail.com>
Cc: <linux-mtd@lists.infradead.org>,
David Woodhouse <dwmw2@infradead.org>,
<linux-kernel@vger.kernel.org>,
Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH] MTD: MAPS: bcm963xx-flash.c: explicitly include module.h
Date: Sun, 6 Nov 2011 20:26:43 -0500 [thread overview]
Message-ID: <20111107012643.GG30282@windriver.com> (raw)
In-Reply-To: <1320580651-4860-1-git-send-email-jonas.gorski@gmail.com>
[[PATCH] MTD: MAPS: bcm963xx-flash.c: explicitly include module.h] On 06/11/2011 (Sun 12:57) Jonas Gorski wrote:
> module.h was previously implicitly included through mtd/mtd.h.
>
> Fixes the following build failure after the module.h cleanup:
>
> CC drivers/mtd/maps/bcm963xx-flash.o
> drivers/mtd/maps/bcm963xx-flash.c: In function 'bcm963xx_probe':
> drivers/mtd/maps/bcm963xx-flash.c:208:29: error: 'THIS_MODULE' undeclared (first use in this function)
> drivers/mtd/maps/bcm963xx-flash.c:208:29: note: each undeclared identifier is reported only once for each function it appears in
> drivers/mtd/maps/bcm963xx-flash.c: At top level:
> drivers/mtd/maps/bcm963xx-flash.c:255:12: error: 'THIS_MODULE' undeclared here (not in a function)
> drivers/mtd/maps/bcm963xx-flash.c:272:16: error: expected declaration specifiers or '...' before string constant
> drivers/mtd/maps/bcm963xx-flash.c:272:1: warning: data definition has no type or storage class
> drivers/mtd/maps/bcm963xx-flash.c:272:1: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
> drivers/mtd/maps/bcm963xx-flash.c:272:16: warning: function declaration isn't a prototype
> drivers/mtd/maps/bcm963xx-flash.c:273:20: error: expected declaration specifiers or '...' before string constant
> drivers/mtd/maps/bcm963xx-flash.c:273:1: warning: data definition has no type or storage class
> drivers/mtd/maps/bcm963xx-flash.c:273:1: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
> drivers/mtd/maps/bcm963xx-flash.c:273:20: warning: function declaration isn't a prototype
> drivers/mtd/maps/bcm963xx-flash.c:274:15: error: expected declaration specifiers or '...' before string constant
> drivers/mtd/maps/bcm963xx-flash.c:274:1: warning: data definition has no type or storage class
> drivers/mtd/maps/bcm963xx-flash.c:274:1: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
> drivers/mtd/maps/bcm963xx-flash.c:274:15: warning: function declaration isn't a prototype
> drivers/mtd/maps/bcm963xx-flash.c:275:15: error: expected declaration specifiers or '...' before string constant
> drivers/mtd/maps/bcm963xx-flash.c:275:1: warning: data definition has no type or storage class
> drivers/mtd/maps/bcm963xx-flash.c:275:1: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
> drivers/mtd/maps/bcm963xx-flash.c:275:15: warning: function declaration isn't a prototype
> drivers/mtd/maps/bcm963xx-flash.c:276:15: error: expected declaration specifiers or '...' before string constant
> drivers/mtd/maps/bcm963xx-flash.c:276:1: warning: data definition has no type or storage class
> drivers/mtd/maps/bcm963xx-flash.c:276:1: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
> drivers/mtd/maps/bcm963xx-flash.c:276:15: warning: function declaration isn't a prototype
> make[7]: *** [drivers/mtd/maps/bcm963xx-flash.o] Error 1
>
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
> ---
>
> This patch is based on next-20111104 and probably should go through Paul's module.h cleanup tree.
I can put it in the module.h tree, but for files that are using module.h
stuff, they can simply add it via the normal maintainer flow, since
files that use modular stuff should include module.h regardless and
there are no dependencies on the module.h content for things like this.
Thanks,
Paul.
>
> drivers/mtd/maps/bcm963xx-flash.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/maps/bcm963xx-flash.c b/drivers/mtd/maps/bcm963xx-flash.c
> index 608967f..736ca10 100644
> --- a/drivers/mtd/maps/bcm963xx-flash.c
> +++ b/drivers/mtd/maps/bcm963xx-flash.c
> @@ -21,6 +21,7 @@
> #include <linux/init.h>
> #include <linux/kernel.h>
> #include <linux/slab.h>
> +#include <linux/module.h>
> #include <linux/mtd/map.h>
> #include <linux/mtd/mtd.h>
> #include <linux/mtd/partitions.h>
> --
> 1.7.2.5
>
next prev parent reply other threads:[~2011-11-07 1:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-06 11:57 [PATCH] MTD: MAPS: bcm963xx-flash.c: explicitly include module.h Jonas Gorski
2011-11-07 1:26 ` Paul Gortmaker [this message]
2011-11-07 10:12 ` Jonas Gorski
2011-11-07 16:30 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111107012643.GG30282@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=dwmw2@infradead.org \
--cc=florian@openwrt.org \
--cc=jonas.gorski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox