From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Yinghai Lu <yinghai.lu@oracle.com>
Cc: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Subject: Re: [PATCH -v2] pciehp: Retrieve link speed after link is trained
Date: Mon, 7 Nov 2011 08:07:50 -0800 [thread overview]
Message-ID: <20111107080750.14b4bdd5@jbarnes-desktop> (raw)
In-Reply-To: <4EB7FEF3.7090105@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 497 bytes --]
On Mon, 07 Nov 2011 07:53:23 -0800
Yinghai Lu <yinghai.lu@oracle.com> wrote:
>
> During hot plug, board_added will call pciehp_power_on_slot().
> But link speed is updated in pciehp_power_on_slot().
>
> We should not update link speed there, because that is too early.
>
> Move updating to pciehp_check_link_status() after making sure link is trained.
>
> -v2: compiling warning that Kenji found.
Applied, thanks guys.
--
Jesse Barnes, Intel Open Source Technology Center
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2011-11-07 16:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-09 7:06 [PATCH] pciehp: Retrieve link speed after link is trained Yinghai Lu
2011-11-02 21:05 ` Jesse Barnes
2011-11-03 7:07 ` Kenji Kaneshige
2011-11-07 11:30 ` Kenji Kaneshige
2011-11-07 15:53 ` [PATCH -v2] " Yinghai Lu
2011-11-07 16:07 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111107080750.14b4bdd5@jbarnes-desktop \
--to=jbarnes@virtuousgeek.org \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=yinghai.lu@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).