From: Yong Zhang <yong.zhang0@gmail.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: linux-kernel@vger.kernel.org, sergey.senozhatsky@gmail.com,
bp@alien8.de, Ingo Molnar <mingo@elte.hu>
Subject: Re: [RFC PATCH 4/4] lockdep: fix race condition in __lock_set_class()
Date: Mon, 7 Nov 2011 21:26:02 +0800 [thread overview]
Message-ID: <20111107132602.GA2783@zhy> (raw)
In-Reply-To: <1320669054.18053.25.camel@twins>
On Mon, Nov 07, 2011 at 01:30:54PM +0100, Peter Zijlstra wrote:
> On Fri, 2011-11-04 at 17:26 +0800, Yong Zhang wrote:
> > When someone call lock_set_class() with valid key, nothing
> > protect the initializing of 'lockdep_map'; thus could lead
> > to flase positive warning from lockdep (such as "key not in
> > .data!"). This patch cure that potential issue.
>
> How? that warning is triggered of the lock_class_key * passed into
> lockdep_init_map and is unrelated to the actual content of the
> lockdep_map.
Oh, my fault, the false positive warning could be "non-static key".
But seems we should find the right direction for this bug :)
Some comments in replies to patch#1.
Thanks,
Yong
next prev parent reply other threads:[~2011-11-07 13:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-04 9:26 [PATCH 0/4] patches to cure race in lock_set_class() Yong Zhang
2011-11-04 9:26 ` [PATCH 1/4] lockdep: lock_set_subclass() fix Yong Zhang
2011-11-07 12:34 ` Peter Zijlstra
2011-11-07 13:31 ` Yong Zhang
2011-11-07 14:03 ` Tejun Heo
2011-11-07 13:54 ` Borislav Petkov
2011-11-07 15:28 ` Vegard Nossum
2011-11-07 16:10 ` Peter Zijlstra
2011-11-07 16:21 ` Tejun Heo
2011-11-07 16:26 ` Peter Zijlstra
2011-11-08 2:58 ` Yong Zhang
2011-11-08 3:02 ` Yong Zhang
2011-11-08 7:56 ` Peter Zijlstra
2011-11-08 8:14 ` Yong Zhang
2011-11-08 8:46 ` Peter Zijlstra
2011-11-08 9:07 ` Yong Zhang
2011-11-08 9:37 ` Yong Zhang
2011-11-08 9:40 ` Peter Zijlstra
2011-11-09 8:04 ` [PATCH 1/2] lockdep: kmemcheck: annotate ->lock in lockdep_init_map() Yong Zhang
2011-11-09 8:07 ` [PATCH 2/2] lockdep: always try to set ->class_cache in register_lock_class() lockdep_init_map() Yong Zhang
2011-11-18 23:39 ` [tip:core/locking] lockdep: Always " tip-bot for Yong Zhang
2011-12-06 9:39 ` [tip:core/locking] lockdep, kmemcheck: Annotate ->lock in lockdep_init_map() tip-bot for Yong Zhang
2011-12-06 19:56 ` David Rientjes
2011-12-06 20:14 ` [tip:perf/urgent] " tip-bot for Yong Zhang
2011-11-08 2:22 ` [PATCH 1/4] lockdep: lock_set_subclass() fix Yong Zhang
2011-11-04 9:26 ` [RFC PATCH 2/4] lockdep: Let register_lock_class() can be called with/without graph_lock Yong Zhang
2011-11-04 9:26 ` [RFC PATCH 3/4] lockdep: split lockdep_init_map() Yong Zhang
2011-11-04 9:26 ` [RFC PATCH 4/4] lockdep: fix race condition in __lock_set_class() Yong Zhang
2011-11-07 12:30 ` Peter Zijlstra
2011-11-07 13:26 ` Yong Zhang [this message]
2011-11-06 11:52 ` [PATCH 0/4] patches to cure race in lock_set_class() Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111107132602.GA2783@zhy \
--to=yong.zhang0@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox