From: Alan Cox <alan@linux.intel.com>
To: Ilya Zykov <ilya@ilyx.ru>
Cc: Greg Kroah-Hartman <gregkh@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: PROBLEM: Race condition in tty buffer's function flush_to_ldisc().
Date: Mon, 7 Nov 2011 14:50:05 +0000 [thread overview]
Message-ID: <20111107145005.68ca1050@bob.linux.org.uk> (raw)
In-Reply-To: <4EB7E0C6.7050909@ilyx.ru>
> Of course I know about tty_buffer_flush(), it only read TTY_FLUSHING,
> it can't change TTY_FLUSHING, if flush_to_ldisc() single threaded,
> we can change TTY_FLUSHING only in one place in one time(in
> flush_to_ldisc()), therefor we can use only "set_bit(TTY_FLUSHING,
> &tty->flags)" without test.
Yes.. if you can pin down why in your testing you see the other case
sometimes being true.
Alan
next prev parent reply other threads:[~2011-11-07 14:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 11:14 PROBLEM: Race condition in tty buffer's function flush_to_ldisc() Ilya Zykov
2011-11-07 11:58 ` Alan Cox
2011-11-07 12:20 ` Ilya Zykov
2011-11-07 13:06 ` Alan Cox
2011-11-07 13:44 ` Ilya Zykov
2011-11-07 14:50 ` Alan Cox [this message]
2011-11-07 14:52 ` Ilya Zykov
2011-11-07 18:26 ` Ilya Zykov
2011-11-07 18:39 ` Alan Cox
2011-11-07 18:41 ` Alan Cox
2011-11-07 12:35 ` Ilya Zykov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111107145005.68ca1050@bob.linux.org.uk \
--to=alan@linux.intel.com \
--cc=gregkh@suse.de \
--cc=ilya@ilyx.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox