[PATCH] ext4: add blk_finish_plug in error case of writepages.

[PATCH] ext4: add blk_finish_plug in error case of writepages.

[Namjae Jeon]

blk_finish_plug is needed in error case of writepages.

Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
---
 fs/ext4/inode.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index cc5a6da..18b262b 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -2270,6 +2270,7 @@ retry:
 			ext4_msg(inode->i_sb, KERN_CRIT, "%s: jbd2_start: "
 			       "%ld pages, ino %lu; err %d", __func__,
 				wbc->nr_to_write, inode->i_ino, ret);
+			blk_finish_plug(&plug);
 			goto out_writepages;
 		}
 
-- 
1.7.4.4

Re: [PATCH] ext4: add blk_finish_plug in error case of writepages.

[Kyungmin Park]

It's already fixed after finding the bug by original author.

Thank you,
Kyungmin Park

On Sat, Nov 5, 2011 at 2:49 PM, Namjae Jeon <linkinjeon@gmail.com> wrote:
> blk_finish_plug is needed in error case of writepages.
>
> Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
> ---
>  fs/ext4/inode.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index cc5a6da..18b262b 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -2270,6 +2270,7 @@ retry:
>                        ext4_msg(inode->i_sb, KERN_CRIT, "%s: jbd2_start: "
>                               "%ld pages, ino %lu; err %d", __func__,
>                                wbc->nr_to_write, inode->i_ino, ret);
> +                       blk_finish_plug(&plug);
>                        goto out_writepages;
>                }
>
> --
> 1.7.4.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

Re: [PATCH] ext4: add blk_finish_plug in error case of writepages.

[NamJae Jeon]

2011/11/5 Kyungmin Park <kmpark@infradead.org>:
> It's already fixed after finding the bug by original author.
>
> Thank you,
> Kyungmin Park
Hi. Park.
This bug is not fixed yet on the latest git of ted,
Do I know to be wrong ?
Thanks.
>
> On Sat, Nov 5, 2011 at 2:49 PM, Namjae Jeon <linkinjeon@gmail.com> wrote:
>> blk_finish_plug is needed in error case of writepages.
>>
>> Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
>> ---
>>  fs/ext4/inode.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
>> index cc5a6da..18b262b 100644
>> --- a/fs/ext4/inode.c
>> +++ b/fs/ext4/inode.c
>> @@ -2270,6 +2270,7 @@ retry:
>>                        ext4_msg(inode->i_sb, KERN_CRIT, "%s: jbd2_start: "
>>                               "%ld pages, ino %lu; err %d", __func__,
>>                                wbc->nr_to_write, inode->i_ino, ret);
>> +                       blk_finish_plug(&plug);
>>                        goto out_writepages;
>>                }
>>
>> --
>> 1.7.4.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
>>
>

Re: [PATCH] ext4: add blk_finish_plug in error case of writepages.

[Ted Ts'o]

On Sat, Nov 05, 2011 at 04:25:52PM +0900, Kyungmin Park wrote:
> It's already fixed after finding the bug by original author.

Hmm, if so I must have checked in the wrong version.  My apologies.

I've applied Namjae Jeon patch as it the blk_finish_plug() does seem
to be missing in the error path.

						- Ted