From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752570Ab1KGSz6 (ORCPT ); Mon, 7 Nov 2011 13:55:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:17360 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751352Ab1KGSz5 (ORCPT ); Mon, 7 Nov 2011 13:55:57 -0500 Date: Mon, 7 Nov 2011 13:09:50 -0500 From: Dave Jones To: Borislav Petkov Cc: x86@kernel.org, Linux Kernel , gregkh@suse.de Subject: Re: BAD APICID ? Message-ID: <20111107180950.GA6411@redhat.com> Mail-Followup-To: Dave Jones , Borislav Petkov , x86@kernel.org, Linux Kernel , gregkh@suse.de References: <20111107173948.GA1344@redhat.com> <20111107175402.GA3384@gere.osrc.amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111107175402.GA3384@gere.osrc.amd.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 07, 2011 at 06:54:02PM +0100, Borislav Petkov wrote: > On Mon, Nov 07, 2011 at 12:39:48PM -0500, Dave Jones wrote: > > We got a report from a Fedora user hitting a WARN_ON in the apic setup code. > > > > Here.. > > > > 1230 #ifdef CONFIG_X86_32 > > 1231 /* > > 1232 * APIC LDR is initialized. If logical_apicid mapping was > > 1233 * initialized during get_smp_config(), make sure it matches the > > 1234 * actual value. > > 1235 */ > > 1236 i = early_per_cpu(x86_cpu_to_logical_apicid, cpu); > > 1237 WARN_ON(i != BAD_APICID && i != logical_smp_processor_id()); > > 1238 /* always use the value from LDR */ > > 1239 early_per_cpu(x86_cpu_to_logical_apicid, cpu) = > > 1240 logical_smp_processor_id(); > > > > The full report is at https://bugzilla.redhat.com/show_bug.cgi?id=743930 > > > > Report is against our 3.0 builds, but that code look unchanged in 3.1 too, > > and even in current Linus head. > > > > Any thoughts on what could cause this ? > > Already fixed upstream: 838312be46f3abfbdc175f81c3e54a857994476d > > Here's the whole thread: http://lkml.org/lkml/2011/10/14/231 > > HTH. ah, excellent, thanks. That seems to have not hit stable, even though it was cc'd. Greg ? Dave