From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753372Ab1KGTbV (ORCPT ); Mon, 7 Nov 2011 14:31:21 -0500 Received: from mail-bw0-f46.google.com ([209.85.214.46]:38569 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752515Ab1KGTbT (ORCPT ); Mon, 7 Nov 2011 14:31:19 -0500 Date: Mon, 7 Nov 2011 23:29:15 +0400 From: Vasiliy Kulikov To: kernel-hardening@lists.openwall.com Cc: Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org, Alexey Dobriyan , Andrew Morton , linux-security-module@vger.kernel.org, Linus Torvalds Subject: Re: [kernel-hardening] Re: [PATCH] proc: restrict access to /proc/interrupts Message-ID: <20111107192915.GA4690@albatros> References: <20111107174522.GA2317@albatros> <9718.1320689192@turing-police.cc.vt.edu> <20111107190112.GA3732@albatros> <4EB82F08.8060209@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4EB82F08.8060209@zytor.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 07, 2011 at 11:18 -0800, H. Peter Anvin wrote: > On 11/07/2011 11:01 AM, Vasiliy Kulikov wrote: > > > > What's wrong with old good DAC? You can create a group "sysinfo", do > > "chown sysinfo /proc/interrupts", and add the permitted users to the > > group. If you need to give different access levels to different interrupts, > > you need another /proc/interrupts design, it does nothing with DAC vs. LSM. > > > > I would like to propose that we add a mount option to procfs, and > possibly sysfs, called, say, admingrp. Similar proposals: (procfs for /proc/$PID/* permissions, sorry about different threads) https://lkml.org/lkml/2011/6/15/172 https://lkml.org/lkml/2011/6/15/174 https://lkml.org/lkml/2011/6/15/173 https://lkml.org/lkml/2011/6/15/177 https://lkml.org/lkml/2011/6/15/175 https://lkml.org/lkml/2011/6/15/176 (change uid/gid for newly created sysfs objects) https://lkml.org/lkml/2011/5/18/272 As to procfs, I see no real need of adding mode/group mount option for global procfs files (/proc/interrupts, /proc/stat, etc.) - it can be done by distro specific init scripts (chown+chmod). I don't mind against such an option for the convenience, though. > The current Linux trend seems to be do instead force those users to > become root constantly, which is *not* helping the situation. Agreed. Thanks, -- Vasiliy Kulikov http://www.openwall.com - bringing security into open computing environments