From: Kees Cook <keescook@chromium.org>
To: Bryan Freed <bfreed@chromium.org>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
msb@chromium.org, marco.stornelli@gmail.com,
seiji.aguchi@hds.com
Subject: Re: [PATCH] ramoops: Add a device file for ramoops buffer access.
Date: Mon, 7 Nov 2011 16:36:22 -0800 [thread overview]
Message-ID: <20111108003622.GM21663@outflux.net> (raw)
In-Reply-To: <1320710760-2734-1-git-send-email-bfreed@chromium.org>
Hi Bryan,
On Mon, Nov 07, 2011 at 04:06:00PM -0800, Bryan Freed wrote:
> Add a /dev/ramoops device file that gives direct access to ramoops buffers.
> This interface is cleaner than using /dev/mem to access the buffers because
> we no longer need to lseek() or (for ARM) mmap() to an address specified in
> the sysfs mem_address file.
This looks pretty good, except that I'd also want to remove all the module
parameters since this would bypass CONFIG_STRICT_DEVMEM (imagine a
malicious root user loading this module to spy on RAM via the new
interface).
Last week I actually wrote an entire seq_file interface for ramoops[1], but
it seems it shouldn't live in /proc, so it needs to be reworked a bit to
live in /dev, as you have it.
Perhaps we could merge our efforts?
-Kees
[1] https://gerrit.chromium.org/gerrit/#change,11242
--
Kees Cook
ChromeOS Security
next prev parent reply other threads:[~2011-11-08 0:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 0:06 [PATCH] ramoops: Add a device file for ramoops buffer access Bryan Freed
2011-11-08 0:14 ` Alan Cox
2011-11-08 0:36 ` Kees Cook [this message]
2011-11-08 1:04 ` Bryan Freed
2011-11-08 1:33 ` H. Peter Anvin
2011-11-08 7:58 ` Marco Stornelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111108003622.GM21663@outflux.net \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=bfreed@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
--cc=msb@chromium.org \
--cc=seiji.aguchi@hds.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox