public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	stable@vger.kernel.org
Subject: [PATCH 06/10] ftrace: Remove force undef config value left for testing
Date: Mon, 07 Nov 2011 20:29:45 -0500	[thread overview]
Message-ID: <20111108013038.842359366@goodmis.org> (raw)
In-Reply-To: 20111108012939.372220547@goodmis.org

[-- Attachment #1: Type: text/plain, Size: 1319 bytes --]

From: Steven Rostedt <srostedt@redhat.com>

A forced undef of a config value was used for testing and was
accidently left in during the final commit. This causes x86 to
run slower than needed while running function tracing as well
as causes the function graph selftest to fail when DYNMAIC_FTRACE
is not set. This is because the code in MCOUNT expects the ftrace
code to be processed with the config value set that happened to
be forced not set.

The forced config option was left in by:
    commit 6331c28c962561aee59e5a493b7556a4bb585957
    ftrace: Fix dynamic selftest failure on some archs

Link: http://lkml.kernel.org/r/20111102150255.GA6973@debian

Cc: stable@vger.kernel.org
Reported-by: Rabin Vincent <rabin@rab.in>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 kernel/trace/ftrace.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 077d853..0fcc6ca 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -151,7 +151,6 @@ void clear_ftrace_function(void)
 	ftrace_pid_function = ftrace_stub;
 }
 
-#undef CONFIG_HAVE_FUNCTION_TRACE_MCOUNT_TEST
 #ifndef CONFIG_HAVE_FUNCTION_TRACE_MCOUNT_TEST
 /*
  * For those archs that do not test ftrace_trace_stop in their
-- 
1.7.7



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2011-11-08  1:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-08  1:29 [PATCH 00/10] [GIT PULL] tracing: various fixes Steven Rostedt
2011-11-08  1:29 ` [PATCH 01/10] tracing: fix event_subsystem ref counting Steven Rostedt
2011-11-08  1:29 ` [PATCH 02/10] tracing: Restore system filter behavior Steven Rostedt
2011-11-08  1:29 ` [PATCH 03/10] tracing: Add boiler plate for subsystem filter Steven Rostedt
2011-11-08  1:29 ` [PATCH 04/10] tracing: update Documentation on max preds limit Steven Rostedt
2011-11-08  1:29 ` [PATCH 05/10] lockdep: Show subclass in pretty print of lockdep output Steven Rostedt
2011-11-08  1:29 ` Steven Rostedt [this message]
2011-11-08  1:29 ` [PATCH 07/10] jump_label: jump_label_inc may return before the code is patched Steven Rostedt
2011-11-08  1:29 ` [PATCH 08/10] perf: Fix parsing of __print_flags() in TP_printk() Steven Rostedt
2011-11-08  1:29 ` [PATCH 09/10] ftrace: Fix hash record accounting bug Steven Rostedt
2011-11-08  1:29 ` [PATCH 10/10] tracing/latency: Fix header output for latency tracers Steven Rostedt
2011-11-11  8:33 ` [PATCH 00/10] [GIT PULL] tracing: various fixes Ingo Molnar
2011-11-29 21:33   ` Steven Rostedt
2011-12-03  9:20     ` Ingo Molnar
2011-12-05  0:31       ` Steven Rostedt
2011-12-05  9:47         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111108013038.842359366@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox