public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	stable@vger.kernel.org
Subject: [PATCH 08/10] perf: Fix parsing of __print_flags() in TP_printk()
Date: Mon, 07 Nov 2011 20:29:47 -0500	[thread overview]
Message-ID: <20111108013039.749221110@goodmis.org> (raw)
In-Reply-To: 20111108012939.372220547@goodmis.org

[-- Attachment #1: Type: text/plain, Size: 1126 bytes --]

From: Steven Rostedt <srostedt@redhat.com>

A update is made to the sched:sched_switch event that adds some
logic to the first parameter of the __print_flags() that shows the
state of tasks. This change cause perf to fail parsing the flags.

A simple fix is needed to have the parser be able to process ops
within the argument.

Cc: stable@vger.kernel.org
Reported-by: Andrew Vagin <avagin@openvz.org>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 tools/perf/util/trace-event-parse.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/tools/perf/util/trace-event-parse.c b/tools/perf/util/trace-event-parse.c
index 0a7ed5b..6c164dc 100644
--- a/tools/perf/util/trace-event-parse.c
+++ b/tools/perf/util/trace-event-parse.c
@@ -1537,6 +1537,8 @@ process_flags(struct event *event, struct print_arg *arg, char **tok)
 	field = malloc_or_die(sizeof(*field));
 
 	type = process_arg(event, field, &token);
+	while (type == EVENT_OP)
+		type = process_op(event, field, &token);
 	if (test_type_token(type, token, EVENT_DELIM, ","))
 		goto out_free;
 
-- 
1.7.7



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2011-11-08  1:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-08  1:29 [PATCH 00/10] [GIT PULL] tracing: various fixes Steven Rostedt
2011-11-08  1:29 ` [PATCH 01/10] tracing: fix event_subsystem ref counting Steven Rostedt
2011-11-08  1:29 ` [PATCH 02/10] tracing: Restore system filter behavior Steven Rostedt
2011-11-08  1:29 ` [PATCH 03/10] tracing: Add boiler plate for subsystem filter Steven Rostedt
2011-11-08  1:29 ` [PATCH 04/10] tracing: update Documentation on max preds limit Steven Rostedt
2011-11-08  1:29 ` [PATCH 05/10] lockdep: Show subclass in pretty print of lockdep output Steven Rostedt
2011-11-08  1:29 ` [PATCH 06/10] ftrace: Remove force undef config value left for testing Steven Rostedt
2011-11-08  1:29 ` [PATCH 07/10] jump_label: jump_label_inc may return before the code is patched Steven Rostedt
2011-11-08  1:29 ` Steven Rostedt [this message]
2011-11-08  1:29 ` [PATCH 09/10] ftrace: Fix hash record accounting bug Steven Rostedt
2011-11-08  1:29 ` [PATCH 10/10] tracing/latency: Fix header output for latency tracers Steven Rostedt
2011-11-11  8:33 ` [PATCH 00/10] [GIT PULL] tracing: various fixes Ingo Molnar
2011-11-29 21:33   ` Steven Rostedt
2011-12-03  9:20     ` Ingo Molnar
2011-12-05  0:31       ` Steven Rostedt
2011-12-05  9:47         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111108013039.749221110@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox