From: Paul Turner <pjt@google.com>
To: linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@elte.hu>
Subject: [patch 2/3] sched: fix buglet in return_cfs_rq_runtime()
Date: Mon, 07 Nov 2011 20:26:34 -0800 [thread overview]
Message-ID: <20111108042736.623812423@google.com> (raw)
In-Reply-To: 20111108042632.977080206@google.com
[-- Attachment #1: sched-bwc-fix_return_cfs_rq_runtime.patch --]
[-- Type: text/plain, Size: 679 bytes --]
In return_cfs_rq_runtime() we want to return bandwidth when there are no
remaining tasks, not "return" when this is the case.
Signed-off-by: Paul Turner <pjt@google.com>
---
kernel/sched_fair.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: tip/kernel/sched_fair.c
===================================================================
--- tip.orig/kernel/sched_fair.c
+++ tip/kernel/sched_fair.c
@@ -1746,7 +1746,7 @@ static __always_inline void return_cfs_r
if (!cfs_bandwidth_used())
return;
- if (!cfs_rq->runtime_enabled || !cfs_rq->nr_running)
+ if (!cfs_rq->runtime_enabled || cfs_rq->nr_running)
return;
__return_cfs_rq_runtime(cfs_rq);
next prev parent reply other threads:[~2011-11-08 4:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 4:26 [patch 0/3] sched: bandwidth-control tweaks for v3.2 Paul Turner
2011-11-08 4:26 ` [patch 1/3] sched: use jump labels to reduce overhead when bandwidth control is inactive Paul Turner
2011-11-08 9:26 ` Peter Zijlstra
2011-11-08 9:28 ` Peter Zijlstra
2011-11-08 9:29 ` Peter Zijlstra
2011-11-11 4:23 ` Paul Turner
2011-11-18 23:42 ` [tip:sched/core] sched: Use " tip-bot for Paul Turner
2011-11-08 4:26 ` Paul Turner [this message]
2011-11-18 23:41 ` [tip:sched/core] sched: Fix buglet in return_cfs_rq_runtime() tip-bot for Paul Turner
2011-11-08 4:26 ` [patch 3/3] From: Ben Segall <bsegall@google.com> Paul Turner
2011-11-10 2:28 ` Paul Turner
2011-11-10 2:30 ` Paul Turner
2011-11-14 10:03 ` Kamalesh Babulal
2011-11-14 12:01 ` Peter Zijlstra
2011-11-15 21:14 ` Benjamin Segall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111108042736.623812423@google.com \
--to=pjt@google.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox