* [PATCH RESEND v2 1/2] mfd: TPS65910: Make usable even if interrupt unused
@ 2011-11-08 13:24 Afzal Mohammed
2011-11-08 13:50 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Afzal Mohammed @ 2011-11-08 13:24 UTC (permalink / raw)
To: linux-kernel, broonie, lrg, sameo, nsekhar; +Cc: linux-omap, Afzal Mohammed
TPS65910 can be used even if interrupt is unused.
Hence let probe succeed in case interrupt can't be
configured and let Kernel only to complain about it
Signed-off-by: Afzal Mohammed <afzal@ti.com>
---
v2: Remove driver simplification that should not have been done
drivers/mfd/tps65910.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index 25d5d72..f3c9be4 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -187,15 +187,11 @@ static int tps65910_i2c_probe(struct i2c_client *i2c,
tps65910_gpio_init(tps65910, pmic_plat_data->gpio_base);
- ret = tps65910_irq_init(tps65910, init_data->irq, init_data);
- if (ret < 0)
- goto err2;
+ tps65910_irq_init(tps65910, init_data->irq, init_data);
kfree(init_data);
return ret;
-err2:
- mfd_remove_devices(tps65910->dev);
err:
kfree(tps65910);
kfree(init_data);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND v2 1/2] mfd: TPS65910: Make usable even if interrupt unused
2011-11-08 13:24 [PATCH RESEND v2 1/2] mfd: TPS65910: Make usable even if interrupt unused Afzal Mohammed
@ 2011-11-08 13:50 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2011-11-08 13:50 UTC (permalink / raw)
To: Afzal Mohammed; +Cc: linux-kernel, lrg, sameo, nsekhar, linux-omap
On Tue, Nov 08, 2011 at 06:54:03PM +0530, Afzal Mohammed wrote:
> TPS65910 can be used even if interrupt is unused.
> Hence let probe succeed in case interrupt can't be
> configured and let Kernel only to complain about it
>
> Signed-off-by: Afzal Mohammed <afzal@ti.com>
Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-08 13:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-08 13:24 [PATCH RESEND v2 1/2] mfd: TPS65910: Make usable even if interrupt unused Afzal Mohammed
2011-11-08 13:50 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox