From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756199Ab1KHRYF (ORCPT ); Tue, 8 Nov 2011 12:24:05 -0500 Received: from am1ehsobe002.messaging.microsoft.com ([213.199.154.205]:13914 "EHLO AM1EHSOBE002.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751247Ab1KHRYB (ORCPT ); Tue, 8 Nov 2011 12:24:01 -0500 X-SpamScore: -18 X-BigFish: VPS-18(zz1432N98dKzz1202hzz15d4R8275bhz32i668h839h944h62h) X-Spam-TCS-SCL: 1:0 X-Forefront-Antispam-Report: CIP:163.181.249.108;KIP:(null);UIP:(null);IPVD:NLI;H:ausb3twp01.amd.com;RD:none;EFVD:NLI X-FB-SS: 0, X-WSS-ID: 0LUCQZP-01-EUV-02 X-M-MSG: Date: Tue, 8 Nov 2011 18:23:48 +0100 From: "Roedel, Joerg" To: Alex Williamson CC: "dwmw2@infradead.org" , "iommu@lists.linux-foundation.org" , "linux-kernel@vger.kernel.org" , "chrisw@redhat.com" , "agraf@suse.de" , "dwg@au1.ibm.com" , "scottwood@freescale.com" , "B08248@freescale.com" , "benh@kernel.crashing.org" Subject: Re: [PATCH 2/4] intel-iommu: Implement iommu_device_group Message-ID: <20111108172348.GF5182@amd.com> References: <20111021195412.8438.9951.stgit@s20.home> <20111021195611.8438.84499.stgit@s20.home> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20111021195611.8438.84499.stgit@s20.home> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginatorOrg: amd.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 21, 2011 at 03:56:11PM -0400, Alex Williamson wrote: > We generally have BDF granularity for devices, so we just need > to make sure devices aren't hidden behind PCIe-to-PCI bridges. > We can then make up a group number that's simply the concatenated > seg|bus|dev|fn so we don't have to track them (not that users > should depend on that). > > Signed-off-by: Alex Williamson David, does this look good to you? Can you send an Acked-by if its okay? -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632