From: David Brown <davidb@codeaurora.org>
To: Thomas Meyer <thomas@m3y3r.de>
Cc: Richard Kuo <rkuo@codeaurora.org>, Arnd Bergmann <arnd@arndb.de>,
linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Hexagon: Use resource_size function
Date: Tue, 8 Nov 2011 17:02:02 -0800 [thread overview]
Message-ID: <20111109010202.GA16505@huya.qualcomm.com> (raw)
In-Reply-To: <1320778170.8062.134.camel@localhost.localdomain>
Some minor nits about the formatting of the patch.
On Tue, Nov 08, 2011 at 07:49:30PM +0100, Thomas Meyer wrote:
> From: Thomas Meyer <thomas@m3y3r.de>
Shouldn't need a From: line, since it is the same as the email you
sent it from.
> Use resource_size function on resource object
> instead of explicit computation.
The commit text shouldn't be indented.
> The semantic patch that makes this change is available
> in scripts/coccinelle/api/resource_size.cocci.
>
> More information about semantic patching is available at
> http://coccinelle.lip6.fr/
I'm curious if these patches are generated directly by coccinelle,
since they don't appear to be coming from git. It'd be nice to have
diffstats in them (especially when they are larger).
Thanks,
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-11-09 1:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 18:49 [PATCH] Hexagon: Use resource_size function Thomas Meyer
2011-11-09 1:02 ` David Brown [this message]
2011-11-10 8:39 ` Thomas Meyer
2011-11-10 15:28 ` David Brown
2011-11-09 5:33 ` rkuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111109010202.GA16505@huya.qualcomm.com \
--to=davidb@codeaurora.org \
--cc=arnd@arndb.de \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkuo@codeaurora.org \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox