Re: [PATCH] pci: More PRI/PASID cleanup

Roedel, Joerg
2011-11-08T16:44:01Z

On Wed, Nov 02, 2011 at 11:53:56PM -0400, Alex Williamson wrote:
> More consistency cleanups. Drop the _OFF, separate and indent
> CTRL/CAP/STATUS bit definitions, fix that PASID_CAP doesn't
> actually report the ENABLE bit.
>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
>
> Joerg, I can't test this, so you may want to make sure I'm not
> breaking your API. The March 31, 2011 version of the PASID ECN
> shows bit 0 of the PASID capability register as reserved, not
> an indicator of support for or status of the enable bit.
> Presumably the entire capability wouldn't be included if it
> can't be enabled. With the below, pci_enable_pasid() now checks
> the right bit, but also pci_pasid_features() no longer masks in
> bit 0, but being reserved, it should have been clear anyway.

Looks like you are only renaming stuff. I don't see the real point but I
also don't object unless this will be merged upstream soon. I plan to
push the code using these capabilities for the next merge-window and if
this one will me merged then too it will cause a lot of pain.