From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Paul Durrant <Paul.Durrant@citrix.com>
Cc: "annie.li@oracle.com" <annie.li@oracle.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jeremy@goop.org" <jeremy@goop.org>,
"kurt.hackel@oracle.com" <kurt.hackel@oracle.com>
Subject: Re: [PATCH 1/3] Introducing grant table V2 stucture
Date: Wed, 9 Nov 2011 09:49:22 -0500 [thread overview]
Message-ID: <20111109144922.GC8410@phenom.dumpdata.com> (raw)
In-Reply-To: <291EDFCB1E9E224A99088639C4762022B4543AB1BD@LONPMAILBOX01.citrite.net>
On Wed, Nov 09, 2011 at 11:11:22AM +0000, Paul Durrant wrote:
> Annie,
>
> Comments inline below...
>
> > -----Original Message-----
> [snip]
> > -static struct grant_entry *shared;
> > +static union {
> > + struct grant_entry_v1 *v1;
> > + void *ring_addr;
> > +} shared;
> > +
>
> 'ring_addr' seems like the wrong name here; how about 'raw'?
Or 'ring'. I asked Annie to change it from 'raw' to something else and the first
thing that came in my mind was 'ring_addr'. But this does not point to a ring, so
the 'ring' part is wrong.
Point here is to make it descriptive. 'raw' does not carry meaning of _what_
it is suppose to do.
next prev parent reply other threads:[~2011-11-09 14:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 8:12 patches of upstreaming grant table version 2 ANNIE LI
2011-11-09 8:14 ` [PATCH 1/3] Introducing grant table V2 stucture annie.li
2011-11-09 11:11 ` Paul Durrant
2011-11-09 14:49 ` Konrad Rzeszutek Wilk [this message]
2011-11-09 14:56 ` Paul Durrant
[not found] ` <4EBAA3B1.8010401@oracle.com>
2011-11-09 16:22 ` [Xen-devel] " Ian Campbell
2011-11-10 1:56 ` ANNIE LI
[not found] ` <4EBAA566.80909@oracle.com>
2011-11-09 16:14 ` Paul Durrant
2011-11-10 1:50 ` [Xen-devel] " ANNIE LI
2011-11-09 13:28 ` [Xen-devel] " Ian Campbell
2011-11-09 8:15 ` [PATCH 2/3] Grant tables v2 implementation annie.li
2011-11-09 13:32 ` [Xen-devel] " Ian Campbell
2011-11-09 8:16 ` [PATCH 3/3] code clean up annie.li
2011-11-09 11:15 ` Paul Durrant
2011-11-09 12:18 ` [Xen-devel] " Ian Campbell
2011-11-09 9:05 ` [Xen-devel] patches of upstreaming grant table version 2 ANNIE LI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111109144922.GC8410@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Paul.Durrant@citrix.com \
--cc=annie.li@oracle.com \
--cc=jeremy@goop.org \
--cc=kurt.hackel@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox