From: Borislav Petkov <bp@amd64.org>
To: Tony Luck <tony.luck@gmail.com>
Cc: "Niklas Söderlund" <niklas.soderlund@ericsson.com>,
"dougthompson@xmission.com" <dougthompson@xmission.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] amd64_edac: fix size decoding error on K8
Date: Wed, 9 Nov 2011 22:00:52 +0100 [thread overview]
Message-ID: <20111109210052.GJ14181@aftab> (raw)
In-Reply-To: <CA+8MBbLuhhTZW9vB7GvLCd8Uu7bgfUqkO7wu4=Pt7EWyQx0LrQ@mail.gmail.com>
On Wed, Nov 09, 2011 at 12:50:42PM -0800, Tony Luck wrote:
> On Wed, Nov 9, 2011 at 12:35 PM, Borislav Petkov <bp@amd64.org> wrote:
> > + diff = cs_mode / 3 + (unsigned)(cs_mode > 5);
> > +
> > + return 32 << (cs_mode - diff);
>
> Code is correct - but looks like an entry for an obfuscated C
> competition.
I know, right?! Especially casting the boolean to an unsigned int. Yuck!
But it is compact the stupid thing.
> Perhaps it deserves a comment!
Sure it does, will do.
Thanks.
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
next prev parent reply other threads:[~2011-11-09 21:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 14:32 [PATCH] amd64_edac: fix size decoding error on K8 Niklas Söderlund
2011-11-09 14:42 ` Borislav Petkov
2011-11-09 15:13 ` Niklas Söderlund
2011-11-09 20:35 ` Borislav Petkov
2011-11-09 20:50 ` Tony Luck
2011-11-09 21:00 ` Borislav Petkov [this message]
2011-11-14 16:54 ` [PATCH] amd64_edac: Fix K8 revD and later chip select sizes Borislav Petkov
2011-11-15 8:10 ` Niklas Söderlund
2011-11-09 20:51 ` [PATCH] amd64_edac: fix size decoding error on K8 Nils Carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111109210052.GJ14181@aftab \
--to=bp@amd64.org \
--cc=dougthompson@xmission.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=niklas.soderlund@ericsson.com \
--cc=tony.luck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox