Re: [PATCH] nilfs2: unbreak compat ioctl

[Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>]

On Mon, 07 Nov 2011 21:18:37 +0100, Thomas Meyer wrote:
> I guess commit 828b1c50ae11e6dda68f8dfefe43b74c7182b157 incidentally broke
> all other compat ioctls. make them work again.
> 
> Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
> ---
>  fs/nilfs2/ioctl.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/nilfs2/ioctl.c b/fs/nilfs2/ioctl.c
> index 41d6743..1773a98 100644
> --- a/fs/nilfs2/ioctl.c
> +++ b/fs/nilfs2/ioctl.c
> @@ -842,8 +842,6 @@ long nilfs_compat_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
>  	case FS_IOC32_GETVERSION:
>  		cmd = FS_IOC_GETVERSION;
>  		break;
> -	default:
> -		return -ENOIOCTLCMD;
>  	}
>  	return nilfs_ioctl(filp, cmd, (unsigned long)compat_ptr(arg));
>  }
> -- 
> 1.7.7

Hi, thank you for pointing this out.

But, this patch looks to prevent compat_sys_ioctl() from handling
other compatible ioctls that compat_ioctl_check_table function
detects.  For instance, fiemap (FS_IOC_FIEMAP) is handled via the
function.

I think we should only redirect own ioctl commands
(i.e. NILFS_IOCTL_xxxx) to the nilfs_ioctl() call.


Regards,
Ryusuke Konishi