From: Simon Horman <horms@verge.net.au>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Dave Young <dyoung@redhat.com>,
kexec@lists.infradead.org, ebiederm@xmission.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kdump: kill redundant code
Date: Thu, 10 Nov 2011 11:33:34 +0900 [thread overview]
Message-ID: <20111110023333.GL9202@verge.net.au> (raw)
In-Reply-To: <20111109152012.GA12537@redhat.com>
On Wed, Nov 09, 2011 at 10:20:13AM -0500, Vivek Goyal wrote:
> On Wed, Nov 09, 2011 at 03:04:52PM +0800, Dave Young wrote:
> > in while loop below, hole_end > crashk_res.end is impossible:
> > while (hole_end <= crashk_res.end) {
> > [snip]
> > }
> > Killing the check code here
> >
> > Signed-off-by: Dave Young <dyoung@redhat.com>
>
> Makes sense.
>
> Acked-by: Vivek Goyal <vgoyal@redhat.com>
Indeed it does. I wonder if this was always so redundant.
Acked-by: Simon Horman <horms@verge.net.au>
prev parent reply other threads:[~2011-11-10 2:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 7:04 [PATCH] kdump: kill redundant code Dave Young
2011-11-09 15:20 ` Vivek Goyal
2011-11-10 2:33 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111110023333.GL9202@verge.net.au \
--to=horms@verge.net.au \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox