Re: [PATCH] KVM: Add wrapper script around QEMU to test kernels

Gerd Hoffmann
2011-11-07T12:19:11Z

On 11/07/11 12:44, Pekka Enberg wrote:
> On Mon, Nov 7, 2011 at 1:02 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> Indeed I do not see any advantage, since all the interfaces they use are
>> stable anyway (sysfs, msr.ko).
>>
>> If they had gone in x86info, for example, my distro (F16, not exactly
>> conservative) would have likely picked those tools up already, but it
>> didn't.
>
> Distributing userspace tools in the kernel tree is a relatively new
> concept so it's not at all surprising distributions don't pick them up
> as quickly. That doesn't mean it's a fundamentally flawed approach,
> though.

tools/ lacks a separation into "kernel hacker's testing+debugging
toolbox" and "userspace tools". It lacks proper buildsystem integration
for the userspace tools, there is no "make tools" and also no "make
tools_install". Silently dropping new stuff into tools/ and expecting
the world magically noticing isn't going to work.

cheers,
Gerd