From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934405Ab1KJNZM (ORCPT <rfc822;w@1wt.eu>);
	Thu, 10 Nov 2011 08:25:12 -0500
Received: from opensource.wolfsonmicro.com ([80.75.67.52]:59788 "EHLO
	opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1755894Ab1KJNZK (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 10 Nov 2011 08:25:10 -0500
Date: Thu, 10 Nov 2011 13:25:06 +0000
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        guenter.roeck@ericsson.com, khali@linux-fr.org,
        dmitry.torokhov@gmail.com, gregkh@suse.de, alan@lxorguk.ukuu.org.uk,
        arnd@arndb.de, linus.walleij@linaro.org, lars@metafoo.de,
        maxime.ripard@free-electrons.com, lm-sensors@lm-sensors.org,
        thomas.petazzoni@free-electrons.com, zdevai@gmail.com,
        Jonathan Cameron <jic23@cam.ac.uk>
Subject: Re: [PATCH 3/5] IIO:CORE add in kernel interface mapping and getting
 IIO channels.
Message-ID: <20111110132506.GF3832@opensource.wolfsonmicro.com>
References: <1320680681-5635-1-git-send-email-jic23@kernel.org>
 <1320680681-5635-4-git-send-email-jic23@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1320680681-5635-4-git-send-email-jic23@kernel.org>
X-Cookie: You are standing on my toes.
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 07, 2011 at 03:44:39PM +0000, Jonathan Cameron wrote:
> From: Jonathan Cameron <jic23@cam.ac.uk>
> 
> Two elements here:
> * Map as defined in include/linux/iio/inkern.h
> * Matching code to actually get the iio_dev and channel
> that we want from the global list of IIO devices.

I've not read it thoroughly but this certainly this looks sensible from
an external interface point of view, I'd expect that issues can be
worked through incrementally.

Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

> +extern struct list_head iio_map_list;

It's surprising that this is part of the external interface of IIO
rather than something hidden within the implementation.