From: "Serge E. Hallyn" <serge.hallyn@canonical.com>
To: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, serge@hallyn.com, oleg@redhat.com
Subject: Re: [MAILER-DAEMON@mail.linuxfoundation.org: Undelivered Mail Returned to Sender]
Date: Thu, 10 Nov 2011 08:32:43 -0600 [thread overview]
Message-ID: <20111110143243.GB7727@sergelap> (raw)
In-Reply-To: <CAKiorj6LYYC+rZG5CRKahYuzyXdnGpQJgd4QQUQ9YhHpTV7s=w@mail.gmail.com>
...
> > Would you prefer something like:
> >
> > +#ifdef CONFIG_USER_NS
> > +static inline void fixup_uid(struct siginfo *info, struct task_struct *t)
> > +{
> > + if (current_user_ns() == task_cred_xxx(t, user_ns))
> > + return;
> > +
> > + if (SI_FROMKERNEL(info))
> > + return;
> > +
> > + info->si_uid = user_ns_map_uid(task_cred_xxx(t, user_ns),
> > + current_cred(), info->si_uid);
> > +}
> > +#else
> > +static inline void fixup_uid(struct siginfo *info, struct task_struct *t)
> > +{
> > + return;
> > +}
> > +#endif
> >
> > ? It's less sneaky at least.
>
> Very much. The current version looks like a bug.
Thanks, I'll switch to that and hopefully resend the set soon.
-serge
parent reply other threads:[~2011-11-10 14:32 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CAKiorj6LYYC+rZG5CRKahYuzyXdnGpQJgd4QQUQ9YhHpTV7s=w@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111110143243.GB7727@sergelap \
--to=serge.hallyn@canonical.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox