From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935235Ab1KJP2b (ORCPT ); Thu, 10 Nov 2011 10:28:31 -0500 Received: from wolverine01.qualcomm.com ([199.106.114.254]:18304 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933707Ab1KJP2a (ORCPT ); Thu, 10 Nov 2011 10:28:30 -0500 X-IronPort-AV: E=McAfee;i="5400,1158,6525"; a="136435204" Date: Thu, 10 Nov 2011 07:28:25 -0800 From: David Brown To: Thomas Meyer Cc: David Brown , Richard Kuo , Arnd Bergmann , linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Hexagon: Use resource_size function Message-ID: <20111110152825.GA13341@huya.qualcomm.com> References: <1320778170.8062.134.camel@localhost.localdomain> <20111109010202.GA16505@huya.qualcomm.com> <1320914364.20155.10.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1320914364.20155.10.camel@localhost.localdomain> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 10, 2011 at 09:39:24AM +0100, Thomas Meyer wrote: > Am Dienstag, den 08.11.2011, 17:02 -0800 schrieb David Brown: > > Some minor nits about the formatting of the patch. > > > > On Tue, Nov 08, 2011 at 07:49:30PM +0100, Thomas Meyer wrote: > > > From: Thomas Meyer > > > > Shouldn't need a From: line, since it is the same as the email you > > sent it from. > > So do I need a From: line or not? > > Documentation/SubmittingPatches says: > > The "from" line must be the very first line in the message body, > and has the form: > > From: Original Author > > The "from" line specifies who will be credited as the author of the > patch in the permanent changelog. If the "from" line is missing, > then the "From:" line from the email header will be used to determine > the patch author in the changelog. > > MUST in the meaning of RFC2119, means it is an absolut requirment. What > should I do? The absolute requirement is that the from line must be the first line in the message body. The "If the 'from' line is missing" even suggests that it is optional. I agree that the wording isn't all that great. I don't believe it hurts anything to use it, it just looks kind of odd to have a From line that is the same as the originating email address. You certainly don't need it, given that a vast majority of patches posted don't contain a from line. Git send-email only generates one if the author is different from the one sending the message. David -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.