From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757725Ab1KJPqA (ORCPT ); Thu, 10 Nov 2011 10:46:00 -0500 Received: from mail-ey0-f174.google.com ([209.85.215.174]:64331 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752286Ab1KJPp6 (ORCPT ); Thu, 10 Nov 2011 10:45:58 -0500 Date: Thu, 10 Nov 2011 07:45:50 -0800 From: Tejun Heo To: Alan Stern Cc: Lin Ming , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org, Jeff Garzik , "Rafael J. Wysocki" , James Bottomley , Huang Ying , Zhang Rui Subject: Re: [PATCH v2 4/4] ata: add ata port runtime PM callbacks Message-ID: <20111110154550.GF27258@google.com> References: <1320906166-15459-5-git-send-email-ming.m.lin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 10, 2011 at 10:40:21AM -0500, Alan Stern wrote: > Are you really sure you want to keep this flag set throughout the > lifetime of the port? > > What happens if a command fails, then the port suspends, and then the > error handler is invoked to take care of the failed command? Runtime PM doesn't happen if the device is in use in any way, so there's no request flying in from upper layers. While the port is suspended, qc's which which requested EH are short-circuited. AFAICS, nothing is really wrong. Thanks. -- tejun