From: Joerg Roedel <joerg.roedel@amd.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: David Airlie <airlied@linux.ie>, <linux-kernel@vger.kernel.org>,
<iommu@lists.linux-foundation.org>,
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] iommu/intel: Fix build failure with intel-gtt and !intel-iommu
Date: Fri, 11 Nov 2011 15:24:16 +0100 [thread overview]
Message-ID: <20111111142416.GK13213@amd.com> (raw)
In-Reply-To: <1321019553.2027.47.camel@shinybook.infradead.org>
On Fri, Nov 11, 2011 at 01:52:33PM +0000, David Woodhouse wrote:
> On Fri, 2011-11-11 at 14:48 +0100, Joerg Roedel wrote:
> > +#define intel_iommu_gfx_mapped 1
>
> That ought to be zero; if the IOMMU code isn't present, it's
> *definitely* not mapped through the IOMMU :)
>
> But I'm fairly sure this was already noticed and a patch is on its way
> upstream already.
>
> It's my fault — my original testing patches to expose this information
> from the IOMMU code did put it into a header file, but when I sent it
> upstream I missed that part of the patch, thus leading to the horrid
> 'extern int intel_iommu_gfx_mapped;' in intel-gtt.c that your patch
> removes.
No problem, it was easy to fix :) I'll keep that patch in my out-of-tree
branch until it is fixed upstream.
Joerg
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2011-11-11 14:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 13:48 [PATCH] iommu/intel: Fix build failure with intel-gtt and !intel-iommu Joerg Roedel
2011-11-11 13:52 ` David Woodhouse
2011-11-11 14:24 ` Joerg Roedel [this message]
2011-11-14 13:26 ` Joerg Roedel
2011-11-14 13:35 ` Dave Airlie
2011-11-14 14:29 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111111142416.GK13213@amd.com \
--to=joerg.roedel@amd.com \
--cc=airlied@linux.ie \
--cc=dwmw2@infradead.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox