linux-next: build failure after merge of the pm tree (and warning)

Stephen Rothwell
2011-11-14T02:17:44Z

[-- Attachment #1: Type: text/plain, Size: 1283 bytes --]

Hi Rafael,

After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/dma/dmatest.c: In function 'dmatest_func':
drivers/dma/dmatest.c:255:2: error: implicit declaration of function 'set_freezable_with_signal' [-Werror=implicit-function-declaration]

Caused by commit cd3bc8fbc2d5 ("freezer: kill unused
set_freezable_with_signal()") interacting with commit 981ed70d8e4f
("dmatest: make dmatest threads freezable") from Linus' tree (merged into
v3.2-rc1).

I reverted the pm tree commit for today.

I also noticed this warning:

drivers/dma/dmatest.c: In function 'dmatest_add_channel':
drivers/dma/dmatest.c:594:28: warning: the omitted middle operand in ?: will always be 'true', suggest explicit middle operand [-Wparentheses]

Which has been there since 2009 ... I think points out an error in the
code (looking at the lines above there). The two occurrences above were
fixed in commit f1aef8b6e6ab ("dmaengine: dmatest: correct thread_count
while using multiple thread per channel") but the third came in via a
different branch (commit 58691d64c44a "dmatest: add pq support") and was
not corrected.

--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]