From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752846Ab1KOAvm (ORCPT ); Mon, 14 Nov 2011 19:51:42 -0500 Received: from mail-vw0-f46.google.com ([209.85.212.46]:42542 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751919Ab1KOAvl (ORCPT ); Mon, 14 Nov 2011 19:51:41 -0500 Date: Tue, 15 Nov 2011 01:51:35 +0100 From: Frederic Weisbecker To: Tejun Heo Cc: paul@paulmenage.org, rjw@sisk.pl, lizf@cn.fujitsu.com, linux-pm@lists.linux-foundation.org, linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, matthltc@us.ibm.com, akpm@linux-foundation.org, oleg@redhat.com, kamezawa.hiroyu@Jp.fujitsu.com Subject: Re: [PATCH 09/10] cgroup, cpuset: don't use ss->pre_attach() Message-ID: <20111115005131.GK9446@somewhere> References: <1320191193-8110-1-git-send-email-tj@kernel.org> <1320191193-8110-10-git-send-email-tj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1320191193-8110-10-git-send-email-tj@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 01, 2011 at 04:46:32PM -0700, Tejun Heo wrote: > ->pre_attach() is supposed to be called before migration, which is > observed during process migration but task migration does it the other > way around. The only ->pre_attach() user is cpuset which can do the > same operaitons in ->can_attach(). Collapse cpuset_pre_attach() into > cpuset_can_attach(). > > -v2: Patch contamination from later patch removed. Spotted by Paul > Menage. > > Signed-off-by: Tejun Heo > Acked-by: Paul Menage > Cc: Li Zefan Reviewed-by: Frederic Weisbecker